Skip to content

inner margin too small on printed web pages #17426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RichMorin opened this issue Sep 21, 2014 · 1 comment
Closed

inner margin too small on printed web pages #17426

RichMorin opened this issue Sep 21, 2014 · 1 comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@RichMorin
Copy link

I just printed out a few hundred pages of Rust documentation (eg, manual, tutorial, guides). I'm quite impressed, in general, but I was a bit annoyed by the fact that the horizontal margins are too small to allow safe punching for 3-ring binders.

Please consider adding about 0.25" to the inner margin of the printed CSS format throughout the Rust documentation offerings. If need be, the point size could be reduced a bit so that the total amount of paper remains the same.

-r
@thestinger thestinger added A-docs T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 22, 2014
@frewsxcv frewsxcv mentioned this issue Feb 4, 2015
Closed
@thiagooak thiagooak mentioned this issue Feb 6, 2015
Merged
@steveklabnik
Copy link
Member

#21962 should have addressed this.

lnicola pushed a commit to lnicola/rust that referenced this issue Jun 23, 2024
@bors
Auto merge of rust-lang#17426 - roife:fix-issue-17420, r=Veykril
cbbdf1e 
fix: handle character boundaries for wide chars in extend_selection

fix rust-lang#17420.

When calling 'extend_selection' within a string, r-a attempts to locate the current word at the cursor. This is done by finding the first char before the cursor which is not a letter, digit, or underscore.

The position of this character is referred to as `start_idx`, and the word is considered to start from `start_idx + 1`. However, for wide characters, `start_idx + 1` is not character boundaries, which leading to panic. We should use `ceil_char_boundary` to ensure that the idx is always on character boundaries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @RichMorin @thestinger