-
Notifications
You must be signed in to change notification settings - Fork 13.3k
pub use into the top-level crate module does not work #6745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Should be noted that the fix for #4202 applies specifically to static methods on traits. Impls providing static methods on structs may require similar juggling. I'll try to take a look this week if nobody beats me to it. |
Pretty sure the fix for this would be a generalization of #4202, but the change is a little more involved because we'll need to track the impls associated with exportable items (struct, trait, maybe enum?). |
…teffen Improve accuracy of `mut_key` Fixes rust-lang#6745. Whilst writing the tests for this, I noticed what I believe is a false negative (the code in `@xFrednet's` [comment](rust-lang/rust-clippy#6745 (comment)) doesn't trigger the lint). Currently the tests contain a case for this (which is blatantly ignored), but I'm not at all sure how to implement this (since the lint currently behaves completely differently for ADTs). I'm not sure what should be done - on the one hand the extra test cases are misleading, but on the other hand they don't cause much harm and would save effort for anyone fixing that false negative. --- changelog: Improve accuracy of `clippy::mutable_key_type`.
While #4202 has been fixed, a yet simpler case is still reproducible in current incoming.
If I have a crate def.rs with these definitions:
Then use.rs that uses the crate of def.rs:
Compilation of use.rs fails:
The text was updated successfully, but these errors were encountered: