Highlight rustc's warning/errors in bright-white, similar to Clang #7640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kud1ing if it's light gray it's because your TERM only advertises 8 colors, the terminal library won't use a color the terminal doesn't advertise in the terminfo (it's probably xterm, it should be xterm-256color or somesuch) |
|
Thanks, i wonder what clang does differently. |
|
Landing as part of #7657. |
|
Clang doesn't highlight errors in bright white. It highlights errors in bold. It's only bright white for you because your foreground color is white. |
|
ok |
|
cc #7737, this has made my error messages very sad :( |
|
PR #7716 fixes this. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 28, 2021
…teffen Improve accuracy of `mut_key` Fixes rust-lang#6745. Whilst writing the tests for this, I noticed what I believe is a false negative (the code in `@xFrednet's` [comment](rust-lang/rust-clippy#6745 (comment)) doesn't trigger the lint). Currently the tests contain a case for this (which is blatantly ignored), but I'm not at all sure how to implement this (since the lint currently behaves completely differently for ADTs). I'm not sure what should be done - on the one hand the extra test cases are misleading, but on the other hand they don't cause much harm and would save effort for anyone fixing that false negative. --- changelog: Improve accuracy of `clippy::mutable_key_type`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on Mac OS X this is shown rather in light-gray though. Maybe a bug in term.rs?
Ping @cmr