Skip to content

Rename ast::purity to something else, and rename impure_fn to normal_fn or something #7287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emberian opened this issue Jun 22, 2013 · 1 comment
Closed

Rename ast::purity to something else, and rename impure_fn to normal_fn or something #7287

emberian opened this issue Jun 22, 2013 · 1 comment
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@emberian
Copy link
Member

Maybe fn_modifier? Or fn_style?

Anyway it's a remnant of pure and it needs to be cleaned up.
@metajack
Copy link
Contributor

metajack commented Sep 5, 2013

Visiting for triage. Nothing to add; doesn't seem like a milestone issue, just a bug.

@kaseyc kaseyc mentioned this issue Apr 7, 2014
Closed
@alexcrichton alexcrichton mentioned this issue Apr 10, 2014
Closed
@bors bors closed this as completed in 0156af1 Apr 11, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 3, 2021
@bors
Auto merge of rust-lang#7287 - Jarcho:ice_7272, r=flip1995
5cdba7d 
Fix ICE in `too_many_lines`

fixes: rust-lang#7272
fixes: rust-lang#7286

rust-lang#7272 looks like it's caused by a bug in rust-c. The span it's giving for the closure is:

```rust
$crate:: $lower($d arg) }
        }
    }
}
```

The correct span would be `$crate:: $lower($d arg)` without all the closing braces.

rust-lang#7286 is definitely a clippy bug

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
2 participants
@metajack @emberian