Remove useless namegen thunk #7272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bors
added a commit
that referenced
this pull request
Jun 28, 2013
This removes the `namegen` thunk that was in `common.rs`. I also take the opportunity to refactor a few uses where we had a `str -> ident -> str` chain that seemed somewhat redundant to me. Also cleans up some warnings that made their way in already.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 3, 2021
Fix ICE in `too_many_lines` fixes: rust-lang#7272 fixes: rust-lang#7286 rust-lang#7272 looks like it's caused by a bug in rust-c. The span it's giving for the closure is: ```rust $crate:: $lower($d arg) } } } } ``` The correct span would be `$crate:: $lower($d arg)` without all the closing braces. rust-lang#7286 is definitely a clippy bug changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
namegenthunk that was incommon.rs. I also take the opportunity to refactor a few uses where we had astr -> ident -> strchain that seemed somewhat redundant to me.Also cleans up some warnings that made their way in already.