Unwinding through __morestack on windows does not work #9854
Comments
|
Closing, this will not be landed in this state. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Oct 3, 2024
When there is are multiple references where one of the references isn't mutable then this results in a false-positive for `mut_mutex_lock` as it only checks the mutability of the first reference level. Fix this by using `peel_mid_ty_refs_is_mutable` which correctly determines whether the reference is ultimately mutable and thus whether `Mutex::get_lock()` can actually be used. Fixes rust-lang#9854
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Oct 3, 2024
Fix `mut_mutex_lock` when reference not ultimately mutable When there is are multiple references where one of the references isn't mutable then this results in a false-positive for `mut_mutex_lock` as it only checks the mutability of the first reference level. Fix this by using `peel_mid_ty_refs_is_mutable` which correctly determines whether the reference is ultimately mutable and thus whether `Mutex::get_lock()` can actually be used. Fixes rust-lang#9854 changelog: [`mut_mutex_lock`]: No longer lints if the mutex is behind multiple references and one of those references isn't mutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #9834, we're now using
__morestackin the new runtime in order to catch stack overflow failures. The tests related to this functionality are xfail'd on windows, however, because the unwinder does not want to unwind through the__morestackstack frame (or at least that's my best guess).Nominating for 1.0 high priority, this isn't something which should happen very frequently, but it's frequent enough that we need to be more reasonable than just outright failing on windows.
The text was updated successfully, but these errors were encountered: