Skip to content

Cleanup old issue references #13122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2014

Conversation

mstewartgallus
Copy link
Contributor

Cleanup old issue references. One of these workarounds no longer need to be used anymore and the others are out of date.

@mstewartgallus mstewartgallus changed the title Cleanup workarounds for fixed issues Cleanup old issue references Mar 25, 2014
bors added a commit that referenced this pull request Mar 25, 2014
… r=alexcrichton

Cleanup old issue references. One of these workarounds no longer need to be used anymore and the others are out of date.
@bors bors closed this Mar 25, 2014
@bors bors merged commit ff2f2e8 into rust-lang:master Mar 25, 2014
@mstewartgallus mstewartgallus deleted the cleanup-10734-workarounds branch March 25, 2014 22:45
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 3, 2024
Fix `mut_mutex_lock` when reference not ultimately mutable

When there is are multiple references where one of the references isn't mutable then this results in a false-positive for `mut_mutex_lock` as it only checks the mutability of the first reference level.

Fix this by using `peel_mid_ty_refs_is_mutable` which correctly determines whether the reference is ultimately mutable and thus whether `Mutex::get_lock()` can actually be used.

Fixes rust-lang#9854

changelog: [`mut_mutex_lock`]: No longer lints if the mutex is behind multiple references and one of those references isn't mutable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants