Rename pkgid and PkgId to crateid and CrateId #11182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -610,7 +610,7 @@ the behavior of the compiler. | |||
|
|
|||
| ~~~~ | |||
| // Package ID | |||
| #[ pkgid = "projx#2.5" ]; | |||
| #[ crateid = "projx#2.5" ]; | |||
There was a problem hiding this comment.
crate_id is the attribute name
|
Thanks! Needs a rebase along with the above fixes. |
|
Your comments have been fixed and the commits rebased :) |
This was referenced Dec 29, 2013
|
Tested locally twice and it passed all tests. |
bors
added a commit
that referenced
this pull request
Dec 30, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 31, 2023
[`needless_pass_by_ref_mut`]: Do not lint if passed as a fn-like argument Fixes rust-lang#11182 and also fixes rust-lang#11199 (though this is kind of a duplicate) There's likely a case or two I've missed, so this likely needs a bit more work but it seems to work fine with the tests I've added. PS, the diff for the test is useless because it iterates over a hashmap before linting. Seems to work fine but we could maybe change this for consistency's sake changelog: [`needless_pass_by_ref_mut`]: No longer lints if the function is passed as a fn-like argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11048