Skip to content

Don't label tracking issues with needs-triage #113515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

Don't label tracking issues with needs-triage #113515

merged 1 commit into from
Jul 10, 2023

Conversation

fmease
Copy link
Member

@fmease fmease commented Jul 9, 2023 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Jul 9, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514
Copy link
Member

jyn514 commented Jul 9, 2023 •
edited
Loading

cc #113492 (comment). apparently this is non-deterministic too, ugh. cc @oli-obk @rust-lang/clippy, something in the switch to ui_test is breaking clippy tests. (more details in the linked comment)

@fmease fmease changed the title Don't add label needs-triage to tracking issues Don't label tracking issues with needs-triage Jul 10, 2023
@fmease fmease force-pushed the tracking-issues-dont-need-triage branch from 386f231 to 7d7f6c5 Compare July 10, 2023 03:52
Noratrieb
Noratrieb approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably triage tracking issues more, but triaging new ones really doesn't make sense

@oli-obk
Copy link
Contributor

oli-obk commented Jul 10, 2023

cc #113492 (comment). apparently this is non-deterministic too, ugh. cc @oli-obk @rust-lang/clippy, something in the switch to ui_test is breaking clippy tests. (more details in the linked comment)

I believe I know what it is. I'll create a fix

@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 10, 2023

📌 Commit 7d7f6c5 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023
@Noratrieb
Copy link
Member

r? Nilstrieb

@rustbot rustbot assigned Noratrieb and unassigned Mark-Simulacrum Jul 10, 2023
@Noratrieb Noratrieb mentioned this pull request Jul 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 10, 2023
@bors
Auto merge of rust-lang#113520 - Nilstrieb:rollup-zn78vvp, r=Nilstrieb
a482149 
Rollup of 1 pull requests

Successful merges:

 - rust-lang#113515 (Don't label tracking issues with `needs-triage`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit df2982a into rust-lang:master Jul 10, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 10, 2023
@fmease fmease deleted the tracking-issues-dont-need-triage branch July 10, 2023 10:37
@fmease fmease mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
8 participants
@fmease @rustbot @rust-log-analyzer @jyn514 @oli-obk @Noratrieb @bors @Mark-Simulacrum