Skip to content

Rollup of 1 pull requests #113520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Rollup of 1 pull requests #113520

merged 2 commits into from
Jul 10, 2023

Conversation

Noratrieb
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

fmease and others added 2 commits July 10, 2023 05:45
…riage, r=Nilstrieb

Don't label tracking issues with `needs-triage`

Addresses rust-lang#113261 (comment).

CC `@Nilstrieb`
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. rollup A PR which is a rollup labels Jul 10, 2023
@Noratrieb
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Jul 10, 2023

📌 Commit df2982a has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023
@BoxyUwU
Copy link
Member

BoxyUwU commented Jul 10, 2023

live your dream nils, rollup that one PR

@bors
Copy link
Collaborator

bors commented Jul 10, 2023

⌛ Testing commit df2982a with merge a482149...

@bors
Copy link
Collaborator

bors commented Jul 10, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing a482149 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 10, 2023
@bors bors merged commit a482149 into rust-lang:master Jul 10, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 10, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#113515 Don't label tracking issues with needs-triage 94d8e28b47e097b7522a9c1dbf5ebe1e681f95be (link)

previous master: 743333f3dd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@Noratrieb Noratrieb deleted the rollup-zn78vvp branch July 10, 2023 11:09
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a482149): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.3% [-4.3%, -4.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.3% [3.3%, 3.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-5.4% [-5.4%, -5.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.0% [-5.4%, 3.3%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.93s -> 658.809s (0.29%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants