Subtree update of rust-analyzer
#140385
Open
Subtree update of rust-analyzer
#140385
+33,096
−39,405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Fix, clarify and require a value for `proc_macro_cwd` of `CrateData`
Fix debug sourceFileMap when using cppvsdbg
fix: Cleanup param name inlay hint filtering
fix: Fix new nightly lints
chore: Clean CI a bit
…s-report fix: Fix panic in progress due to splitting unicode incorrectly
We can compute the wanted information from the block's interned data.
Avoid relying on `block_def_map()` needlessly
It doesn't actually work with merge groups ...
chore: Disable rust-cache in CI
chore: Replace some `invoke`s with `invoke_actual` in hir-ty
chore: Remove unnecessary `Arc` clones
…er bug in MBE Specifically, rust-lang#18744 was the PR that was supposed to fix the old bug, but it fixed it incorrectly (and didn't add a test!) The underlying reason was that we marked metavariables in expansions as joint if they were joint in the macro call, which is incorrect. This wrong fix causes other bug, rust-lang#19497, which this PR fixes by removing the old (incorrect) fix.
This was being used by a single assist, which qualifies under the "refactor" kind. The variant has been removed, and all usages updated accordingly. Signed-off-by: Prajwal S N <[email protected]>
Signed-off-by: Prajwal S N <[email protected]>
fix(ide-assists): remove `AssistKind::None`
…s-string Fix color brackets in string context
Signed-off-by: Prajwal S N <[email protected]>
A Cargo project can now be built without any dependency metadata being fetched. Signed-off-by: Prajwal S N <[email protected]>
Implicit field references during struct initialization were being dropped because get_definition was returning None because there were multiple definitions. This adds a new helper, `get_defintions`, that supports returning more than one definition for a given token and hooks it up. Fixes rust-lang#19393
fix: Fix type argument mismatch incorrectly triggering on inferred trait args
Arena allocate `LifetimeRef`s
Always error when failed to parse DiscoverProjectMessage
This saves 18mb on `analysis-stats .`, without regressing speed.
And adapt `intern` to the changes in the API.
It's the intended use.
internal: More `shrink_to_fit()` and upgrade dashmap and hashbrown
…nput minor: Preallocate `parser::Input`
"to arm expression" is hard to parse, because "arm" can be a verb. Not all Rust users may know that "arm" refers to a `match` expression either. Tweak the wording to make the sentence easier to parse, and clarify that this assist refers to `match`. Use the same wording style for the closure version too.
Clarify text for add_braces assist
adds an assist that suggests removing any underscore prefixes from used variables.
…erscore_for_used_var feat: adds an assist to remove underscores from used variables
internal: Sync from downstream
rustbot
added
the
S-waiting-on-review
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-tidy
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
This comment has been minimized.
This comment has been minimized.
|
Quick r? on the license thing, please @davidtwco, @wesleywiser? |
|
Failed to set assignee to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost