Skip to content

current_dll_path: fix mistake in assertion message #141261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

RalfJung
Copy link
Member

Follow-up to #141239
r? @Noratrieb

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2025

Noratrieb is not available for reviewing at the moment.

Please choose another assignee.

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 19, 2025
@Noratrieb
Copy link
Member

right.
also lol I need to remove myself from vacation and just remove myself from the queue
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 19, 2025

📌 Commit c99c4b1 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang#141211 (Replace `try_reserve_exact` with `try_with_capacity` in `std::fs::read`)
 - rust-lang#141257 (trim cache module in utils bootstrap)
 - rust-lang#141259 (Update books)
 - rust-lang#141261 (current_dll_path: fix mistake in assertion message)
 - rust-lang#141262 (Properly remove Noratrieb from review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6461160 into rust-lang:master May 20, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 20, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
Rollup merge of rust-lang#141261 - RalfJung:current_dll_path, r=Noratrieb

current_dll_path: fix mistake in assertion message

Follow-up to rust-lang#141239
r? `@Noratrieb`
@RalfJung RalfJung deleted the current_dll_path branch May 20, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants