Skip to content

Properly remove Noratrieb from review rotation #141262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

Noratrieb
Copy link
Member

I've put myself on vacation a while ago, but really I just want to remove myself from the queue because I couldn't get around to reviewing all the PRs, I'm still here and available :3.

I've put myself on vacation a while ago, but really I just want to remove myself from the queue because I couldn't get around to reviewing all the PRs, I'm still here and available :3.
@rustbot
Copy link
Collaborator

rustbot commented May 19, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 19, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@Noratrieb
Copy link
Member Author

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 19, 2025

📌 Commit 9478598 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2025
@jieyouxu
Copy link
Member

Thanks for all the reviews! 🩵

bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang#141211 (Replace `try_reserve_exact` with `try_with_capacity` in `std::fs::read`)
 - rust-lang#141257 (trim cache module in utils bootstrap)
 - rust-lang#141259 (Update books)
 - rust-lang#141261 (current_dll_path: fix mistake in assertion message)
 - rust-lang#141262 (Properly remove Noratrieb from review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4a47234 into rust-lang:master May 20, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
Rollup merge of rust-lang#141262 - Noratrieb:Noratrieb-patch-4, r=Noratrieb

Properly remove Noratrieb from review rotation

I've put myself on vacation a while ago, but really I just want to remove myself from the queue because I couldn't get around to reviewing all the PRs, I'm still here and available :3.
@rustbot rustbot added this to the 1.89.0 milestone May 20, 2025
@Noratrieb Noratrieb deleted the Noratrieb-patch-4 branch May 20, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants