Fix incorrect eq_unspanned in TokenStream #141570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
is it actually important to those places? |
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
it's also trivial, removed it in new commit 09ecc7e. |
chenyukang
force-pushed
the
yukang-fix-eq_unspanned
branch
3 times, most recently
from
f0cb226 to
a6e3735
Compare
chenyukang
force-pushed
the
yukang-fix-eq_unspanned
branch
from
a6e3735 to
d3347bb
Compare
|
You can use https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.eq_by instead |
feature |
|
Thanks! If we want to use the nightly stdlib feature that seeems fine, but this also seems better, so! @bors r+ rollup |
bors
added
S-waiting-on-bors
chenyukang
added a commit
to chenyukang/rust
that referenced
this pull request
Jun 4, 2025
…, r=workingjubilee Fix incorrect eq_unspanned in TokenStream Fixes rust-lang#141522 r? `@workingjubilee` should we remove this function? since it's used in several places, i'd prefer to keep it.
bors
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup of 6 pull requests Successful merges: - #141250 (add s390x z17 target features) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141959 (Add more missing 2015 edition directives) - #141960 (Use non-2015 edition paths in tests that do not test for their resolution) r? `@ghost` `@rustbot` modify labels: rollup
|
@bors r- |
bors
added
S-waiting-on-author
rust-bors bot
added a commit
that referenced
this pull request
Jun 4, 2025
Fix incorrect eq_unspanned in TokenStream Fixes #141522 r? `@workingjubilee` should we remove this function? since it's used in several places, i'd prefer to keep it. try-job: i686-msvc-1
|
Checking to see if we somehow caused #141995 (comment) |
|
I guess it's okay! @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 4, 2025
…, r=workingjubilee Fix incorrect eq_unspanned in TokenStream Fixes rust-lang#141522 r? `@workingjubilee` should we remove this function? since it's used in several places, i'd prefer to keep it.
bors
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup of 9 pull requests Successful merges: - #141271 (Streamline some attr parsing APIs) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141939 (exact_div: add tests) - #141959 (Add more missing 2015 edition directives) - #142002 (redesign stage 0 std follow-ups part2) - #142007 (Improve some `Visitor` comments.) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup of 7 pull requests Successful merges: - #141271 (Streamline some attr parsing APIs) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141939 (exact_div: add tests) - #141959 (Add more missing 2015 edition directives) - #142007 (Improve some `Visitor` comments.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141522
r? @workingjubilee
should we remove this function?
since it's used in several places, i'd prefer to keep it.