-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rollup of 7 pull requests #142028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #142028
Conversation
They are unused.
They're equivalent, and `path` is unused, and `deconstruct` has only one call site outside of `path`.
And avoid the clone.
- Move explanations into comments to match style - Explain the second examples - Make variable names match the data structure
These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition
For AST/HIR/THIR visitors, explain the use of deconstruction.
…nszelmann Streamline some attr parsing APIs r? ``@jdonszelmann``
…, r=workingjubilee Fix incorrect eq_unspanned in TokenStream Fixes rust-lang#141522 r? ``@workingjubilee`` should we remove this function? since it's used in several places, i'd prefer to keep it.
remove `f16: From<u16>` it's not a lossless conversion r? ``@tgross35``
Lightly tweak docs for BTree{Map,Set}::extract_if - Move explanations into comments to match style - Explain the second examples - Make variable names match the data structure Related rust-lang#70530
…=workingjubilee exact_div: add tests tracking issue: rust-lang#139911 I neglected to add tests in my last PR (rust-lang#141237), so I've added them here. r? ``@workingjubilee`` (Feel free to reroll, I just picked you since you reviewed the last one.)
…es2, r=compiler-errors Add more missing 2015 edition directives These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition
…enyukang Improve some `Visitor` comments. For AST/HIR/THIR visitors, explain the use of deconstruction. r? ``@BoxyUwU``
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: df8102fe5f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing df8102f (parent) -> 4b27a04 (this PR) Test differencesShow 22 test diffsStage 1
Additionally, 12 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4b27a04cc8ed4da10a546a871e23e665d03f7a79 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)
|
Finished benchmarking commit (4b27a04): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary -2.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 749.348s -> 750.448s (0.15%) |
Successful merges:
f16: From<u16>
#141893 (removef16: From<u16>
)Visitor
comments. #142007 (Improve someVisitor
comments.)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup