Skip to content

Do not mention -Zmacro-backtrace for std macros that are a wrapper around a compiler intrinsic #148718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 27, 2026
Merged

Do not mention -Zmacro-backtrace for std macros that are a wrapper around a compiler intrinsic #148718

rust-bors merged 1 commit into from
Jan 27, 2026
+13 −314

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Nov 8, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

The Miri subtree was changed

cc @rust-lang/miri

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Nov 10, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Dec 15, 2025

☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts.

@apiraino
Copy link
Contributor

apiraino commented Jan 22, 2026 •
edited
Loading

r? compiler

@rustbot rustbot assigned nnethercote and unassigned SparrowLii Jan 22, 2026
@rust-lang rust-lang deleted a comment from rustbot Jan 22, 2026
nnethercote
nnethercote approved these changes Jan 23, 2026
View reviewed changes
compiler/rustc_expand/src/base.rs
/// Should debuginfo for the macro be collapsed to the outermost expansion site (in other
/// words, was the macro definition annotated with `#[collapse_debuginfo]`)?
pub collapse_debuginfo: bool,
pub hide_backtrace: bool,
Copy link
Contributor

@nnethercote nnethercote Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment on this field would be good.

@nnethercote
Copy link
Contributor

nnethercote commented Jan 23, 2026

Nice change! Good to see this useless verbiage gone. r=me once the nit above is fixed.

@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor Author

estebank commented Jan 26, 2026

@bors r=nnethercote

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 26, 2026

📌 Commit 4a27be6 has been approved by nnethercote

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 26, 2026
@JonathanBrouwer
Rollup merge of rust-lang#148718 - estebank:macro-spans, r=nnethercote
8fc5de7 
Do not mention `-Zmacro-backtrace` for std macros that are a wrapper around a compiler intrinsic
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 26, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 26, 2026
@matthiaskrgr
Rollup merge of rust-lang#148718 - estebank:macro-spans, r=nnethercote
bdaaeb4 
Do not mention `-Zmacro-backtrace` for std macros that are a wrapper around a compiler intrinsic
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 26, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 26, 2026
@matthiaskrgr
Rollup merge of rust-lang#148718 - estebank:macro-spans, r=nnethercote
00e2f4c 
Do not mention `-Zmacro-backtrace` for std macros that are a wrapper around a compiler intrinsic
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 26, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151713 - matthiaskrgr:rollup-5CzKDNG, r=matthiaskrgr
5c7a135 
Rollup of 6 pull requests

Successful merges:

 - #148718 (Do not mention `-Zmacro-backtrace` for std macros that are a wrapper around a compiler intrinsic)
 - #151137 (checksum-freshness: Fix invalid checksum calculation for binary files)
 - #150863 (Adds two new Tier 3 targets - `aarch64v8r-unknown-none{,-softfloat}`)
 - #151040 (Don't expose redundant information in `rustc_public`'s `LayoutShape`)
 - #151699 (Update books)
 - #151700 (os allow missing_docs)
@Zalathar Zalathar mentioned this pull request Jan 27, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151716 - Zalathar:rollup-kd2N5CM, r=Zalathar
ebf13cc 
Rollup of 12 pull requests

Successful merges:

 - #147996 (Stabilize ppc inline assembly)
 - #148718 (Do not mention `-Zmacro-backtrace` for std macros that are a wrapper around a compiler intrinsic)
 - #151137 (checksum-freshness: Fix invalid checksum calculation for binary files)
 - #151680 (Update backtrace and windows-bindgen)
 - #150863 (Adds two new Tier 3 targets - `aarch64v8r-unknown-none{,-softfloat}`)
 - #151040 (Don't expose redundant information in `rustc_public`'s `LayoutShape`)
 - #151383 (remove `#[deprecated]` from unstable & internal `SipHasher13` and `24` types)
 - #151529 (lint: Use rustc_apfloat for `overflowing_literals`, add f16 and f128)
 - #151669 (rename uN::{gather,scatter}_bits to uN::{extract,deposit}_bits)
 - #151689 (Fix broken Xtensa installation link)
 - #151699 (Update books)
 - #151700 (os allow missing_docs)
@rust-bors rust-bors bot merged commit b4f8dc7 into rust-lang:main Jan 27, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 27, 2026
rust-timer added a commit that referenced this pull request Jan 27, 2026
@rust-timer
Unrolled build for #148718
78a7326 
Rollup merge of #148718 - estebank:macro-spans, r=nnethercote

Do not mention `-Zmacro-backtrace` for std macros that are a wrapper around a compiler intrinsic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nnethercote nnethercote nnethercote approved these changes

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

7 participants

@estebank @rustbot @rust-log-analyzer @bors @apiraino @nnethercote @SparrowLii