rename uN::{gather,scatter}_bits to uN::{extract,deposit}_bits #151669
+74
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
Contributor
Author
|
The feature gate name refers to the previous method names. Would it make sense to also rename that? |
Member
|
I don't think it's worth making people rename their feature gates. We can rename it during stabilization if we want -- the name doesn't actually matter for anything. r=me if CI passes |
4 tasks
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
Rollup of 12 pull requests Successful merges: - #147996 (Stabilize ppc inline assembly) - #148718 (Do not mention `-Zmacro-backtrace` for std macros that are a wrapper around a compiler intrinsic) - #151137 (checksum-freshness: Fix invalid checksum calculation for binary files) - #151680 (Update backtrace and windows-bindgen) - #150863 (Adds two new Tier 3 targets - `aarch64v8r-unknown-none{,-softfloat}`) - #151040 (Don't expose redundant information in `rustc_public`'s `LayoutShape`) - #151383 (remove `#[deprecated]` from unstable & internal `SipHasher13` and `24` types) - #151529 (lint: Use rustc_apfloat for `overflowing_literals`, add f16 and f128) - #151669 (rename uN::{gather,scatter}_bits to uN::{extract,deposit}_bits) - #151689 (Fix broken Xtensa installation link) - #151699 (Update books) - #151700 (os allow missing_docs)
rust-timer
added a commit
that referenced
this pull request
Jan 27, 2026
Rollup merge of #151669 - quaternic:rename-gather-scatter-bits, r=scottmcm rename uN::{gather,scatter}_bits to uN::{extract,deposit}_bits Feature gate: `#![feature(uint_gather_scatter_bits)]` Tracking issue: #149069 Rename the methods as requested in #149069 (comment) - `gather_bits` -> `extract_bits` - `scatter_bits` -> `deposit_bits`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature gate:
#![feature(uint_gather_scatter_bits)]Tracking issue: #149069
Rename the methods as requested in #149069 (comment)
gather_bits->extract_bitsscatter_bits->deposit_bits