Open
Conversation
This has two advantages: * removes a bunch of @ts-expect-error * typos of var names will cause type errors instead of runtime errors
this allows TypeScript to understand the relation between isTrait and traitName's type, getting rid of a type error.
88b4646 made builtin functions hidden, but it doesn't apply to naked functions, which are generated through a different code path.
If late lifetime resolution fails for whatever reason, forward to RBV the guarantee that an error was emitted - thereby eliminating the need for a "hack" to suppress subsequent/superfluous error diagnostics.
It avoids round-tripping through `Location`s if you're working with `Point`s already.
…saethlin,bjorn3 Set hidden visibility on naked functions in compiler-builtins 88b4646 made builtin functions hidden, but it doesn't apply to naked functions, which are generated through a different code path. This was discovered in rust-lang#151486 where aarch64 outline atomics showed up in shared objects, overriding the symbols from compiler-rt.
…table-first, r=notriddle rustdoc: sort stable items first Finally tackling this again now that the search system refactor is done. The tests and the general approach were taken from the original PR.
… r=fmease Feed `ErrorGuaranteed` from late lifetime resolution errors through to bound variable resolution If late lifetime resolution fails for whatever reason, forward to RBV the guarantee that an error was emitted - thereby eliminating the need for a "hack" to suppress subsequent/superfluous error diagnostics. Fixes rust-lang#152014 r? fmease
…unds, r=estebank improve associated-type suggestions from bounds Should address invalid suggestions I could come up with, but the suggestion is too hand-crafted and invalid patterns may exist. r? @estebank Fix rust-lang#73321
move `escape_symbol_name` to `cg_ssa` followup of rust-lang#151955 r? @bjorn3
…richton c-variadic: implement `va_arg` for `wasm64` tracking issue: rust-lang#44930 A LLVM maintainer of the wasm backend confirmed that the behavior on wasm64 is intented: the slot size is 4 on both wasm32 and wasm64. llvm/llvm-project#173580 (comment) r? workingjubilee cc @alexcrichton as target maintainer
…=GuillaumeGomez rustdoc: more js cleanup Continuing the effort of removing `@ts-expect-error` from the codebase wherever possible, this time focusing on `main.js`. Found some oddities with `register_type_impls`, fixed most of them, but the one that I couldn't figure out is what's going on with `sidebarTraitList`. It's queried, then if there are any trait imps, unconditionally overwritten, then latter code assumes that one of these two things has initialized it, but it's not obvious why this would be the case, or if there's a reason this wasn't done in a more straightforwards way. r? @GuillaumeGomez
nix-dev-shell: fix a typo meow r? @WaffleLapkin
…zelmann Port `#[lang]` and `#[panic_handler]` to the new attribute parsers For rust-lang#131229 (comment) r? @jdonszelmann
…r=jackh726 layout_of unexpected rigid alias delayed bug fixes rust-lang#152545. The trait solver can keep aliases as rigid even if they are not well-formed https://github.com/rust-lang/rust/blob/d7daac06d87e1252d10eaa44960164faac46beff/compiler/rustc_next_trait_solver/src/solve/normalizes_to/mod.rs#L315-L345 r? types
A couple of tiny polonius things Here's a couple of tiny things I had ready to go @jackh726 - a tiny cleanup to avoid round-tripping through `Location`s to check for liveness, since we're already working with points - while I was there, I fixed the doc which wasn't showing up properly (maybe a rustdoc or bootstrap bug when we build locally or during dist, either way, both don't show up correctly linked most of the time) for `PointIndex`es. - and in the second commit slightly expand test coverage with [an example](https://internals.rust-lang.org/t/get-mut-map-back-from-entry-api/24003) that would have needed stdlib changes (cc author @Darksonn for visibility here) More soon. r? @jackh726
rustbot
added
A-attributes
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ErrorGuaranteedfrom late lifetime resolution errors through to bound variable resolution #152076 (FeedErrorGuaranteedfrom late lifetime resolution errors through to bound variable resolution)escape_symbol_nametocg_ssa#152573 (moveescape_symbol_nametocg_ssa)va_argforwasm64#152594 (c-variadic: implementva_argforwasm64)#[lang]and#[panic_handler]to the new attribute parsers #152568 (Port#[lang]and#[panic_handler]to the new attribute parsers)r? @ghost
Create a similar rollup