Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests by Ayuse · Pull Request #154587 · rust-lang/rust

Ayuse · 2026-03-30T13:38:14Z

Adds --verbose-run-make-subprocess-output flag to ./x test and compiletest
./x test --no-capture --verbose-run-make-subprocess-output=false suppresses verbose subprocess output for passing run-make tests
Failed tests always print their output regardless of --verbose-run-make-subprocess-output
Default behavior (verbose) is unchanged

This addresses the request from @bjorn3 which needs --no-capture (due to panic=abort) but doesn't want output dumped for every passing test.

Helps with #154069

Test plan

./x test tests/run-make/bare-outfile --no-capture --force-rerun — verbose output for passing test
./x test tests/run-make/bare-outfile --no-capture --verbose-run-make-subprocess-output=false --force-rerun — no verbose output for passing test
Failing test still dumps output with --verbose-run-make-subprocess-output=false

rustbot · 2026-03-30T13:38:17Z

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

The run-make-support library was changed

cc @jieyouxu

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-03-30T13:38:20Z

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu, wesleywiser

Ayuse · 2026-03-30T14:44:54Z

r? @jieyouxu

jieyouxu

Thanks, two things

View changes since this review

rustbot · 2026-04-05T07:58:23Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-04-10T11:35:35Z

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

…tput Add a flag to control verbose subprocess output for run-make tests. When using --no-capture on panic=abort test suites like cg_clif, passing test output can flood the terminal. This flag (default true) lets users opt out via --verbose-run-make-subprocess-output=false. Extract a private print_command_output helper in run-make-support to avoid inlining the output logic in handle_failed_output, ensuring failures always print regardless of the flag.

Ayuse · 2026-04-12T16:31:08Z

@rustbot review

jieyouxu

Tried this locally and seems fine, thanks
@bors r+ rollup

View changes since this review

rust-bors · 2026-04-13T01:44:43Z

📌 Commit 6733ce9 has been approved by jieyouxu

It is now in the queue for this repository.

@bjorn3

…r=jieyouxu Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests - Adds `--verbose-run-make-subprocess-output` flag to `./x test` and compiletest - `./x test --no-capture --verbose-run-make-subprocess-output=false` suppresses verbose subprocess output for passing run-make tests - Failed tests always print their output regardless of `--verbose-run-make-subprocess-output` - Default behavior (verbose) is unchanged This addresses the request from @bjorn3 which needs `--no-capture` (due to `panic=abort`) but doesn't want output dumped for every passing test. Helps with rust-lang#154069 ## Test plan - [x] `./x test tests/run-make/bare-outfile --no-capture --force-rerun` — verbose output for passing test - [x] `./x test tests/run-make/bare-outfile --no-capture --verbose-run-make-subprocess-output=false --force-rerun` — no verbose output for passing test - [x] Failing test still dumps output with `--verbose-run-make-subprocess-output=false`

@bjorn3

…r=jieyouxu Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests - Adds `--verbose-run-make-subprocess-output` flag to `./x test` and compiletest - `./x test --no-capture --verbose-run-make-subprocess-output=false` suppresses verbose subprocess output for passing run-make tests - Failed tests always print their output regardless of `--verbose-run-make-subprocess-output` - Default behavior (verbose) is unchanged This addresses the request from @bjorn3 which needs `--no-capture` (due to `panic=abort`) but doesn't want output dumped for every passing test. Helps with rust-lang#154069 ## Test plan - [x] `./x test tests/run-make/bare-outfile --no-capture --force-rerun` — verbose output for passing test - [x] `./x test tests/run-make/bare-outfile --no-capture --verbose-run-make-subprocess-output=false --force-rerun` — no verbose output for passing test - [x] Failing test still dumps output with `--verbose-run-make-subprocess-output=false`

…uwer Rollup of 13 pull requests Successful merges: - #155162 (relnotes for 1.95) - #140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - #154049 (delegation: Track more precise spans for glob delegations) - #154193 (Implement EII for statics) - #154435 (resolve: Some import resolution cleanups) - #153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - #154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - #154624 (Make `DerefPure` dyn-incompatible) - #154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - #154944 (Small refactor of `arena_cache` query values) - #155131 (Stabilize feature `uint_bit_width`) - #155147 (Stabilize feature `int_lowest_highest_one`) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)

JonathanBrouwer · 2026-04-13T15:21:43Z

@bors try jobs=i686-msvc-2

Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests try-job: i686-msvc-2

@bjorn3

…r=jieyouxu Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests - Adds `--verbose-run-make-subprocess-output` flag to `./x test` and compiletest - `./x test --no-capture --verbose-run-make-subprocess-output=false` suppresses verbose subprocess output for passing run-make tests - Failed tests always print their output regardless of `--verbose-run-make-subprocess-output` - Default behavior (verbose) is unchanged This addresses the request from @bjorn3 which needs `--no-capture` (due to `panic=abort`) but doesn't want output dumped for every passing test. Helps with rust-lang#154069 ## Test plan - [x] `./x test tests/run-make/bare-outfile --no-capture --force-rerun` — verbose output for passing test - [x] `./x test tests/run-make/bare-outfile --no-capture --verbose-run-make-subprocess-output=false --force-rerun` — no verbose output for passing test - [x] Failing test still dumps output with `--verbose-run-make-subprocess-output=false`

rust-bors · 2026-04-13T17:44:57Z

☀️ Try build successful (CI)
Build commit: 0e801c0 (0e801c008b4396740bf244d6bab8659d1de092a6, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

…uwer Rollup of 19 pull requests Successful merges: - #155162 (relnotes for 1.95) - #140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - #153604 (Fix thread::available_parallelism on WASI targets with threads) - #154193 (Implement EII for statics) - #154389 (Add more robust handling of nested query cycles) - #154435 (resolve: Some import resolution cleanups) - #155236 (Normalize individual predicate of `InstantiatedPredicates` inside `predicates_for_generics`) - #155243 (cg_ssa: transmute between scalable vectors) - #153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - #154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - #154624 (Make `DerefPure` dyn-incompatible) - #154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - #154944 (Small refactor of `arena_cache` query values) - #155055 (UI automation) - #155062 (Move tests from `tests/ui/issues/` to appropriate directories) - #155131 (Stabilize feature `uint_bit_width`) - #155147 (Stabilize feature `int_lowest_highest_one`) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint) - #155194 (Fix manpage version replacement and use verbose version)

@bjorn3

Rollup merge of #154587 - Ayuse:compiletest-quiet-run-make, r=jieyouxu Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests - Adds `--verbose-run-make-subprocess-output` flag to `./x test` and compiletest - `./x test --no-capture --verbose-run-make-subprocess-output=false` suppresses verbose subprocess output for passing run-make tests - Failed tests always print their output regardless of `--verbose-run-make-subprocess-output` - Default behavior (verbose) is unchanged This addresses the request from @bjorn3 which needs `--no-capture` (due to `panic=abort`) but doesn't want output dumped for every passing test. Helps with #154069 ## Test plan - [x] `./x test tests/run-make/bare-outfile --no-capture --force-rerun` — verbose output for passing test - [x] `./x test tests/run-make/bare-outfile --no-capture --verbose-run-make-subprocess-output=false --force-rerun` — no verbose output for passing test - [x] Failing test still dumps output with `--verbose-run-make-subprocess-output=false`

…uwer Rollup of 19 pull requests Successful merges: - rust-lang/rust#155162 (relnotes for 1.95) - rust-lang/rust#140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - rust-lang/rust#153604 (Fix thread::available_parallelism on WASI targets with threads) - rust-lang/rust#154193 (Implement EII for statics) - rust-lang/rust#154389 (Add more robust handling of nested query cycles) - rust-lang/rust#154435 (resolve: Some import resolution cleanups) - rust-lang/rust#155236 (Normalize individual predicate of `InstantiatedPredicates` inside `predicates_for_generics`) - rust-lang/rust#155243 (cg_ssa: transmute between scalable vectors) - rust-lang/rust#153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - rust-lang/rust#154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - rust-lang/rust#154624 (Make `DerefPure` dyn-incompatible) - rust-lang/rust#154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - rust-lang/rust#154944 (Small refactor of `arena_cache` query values) - rust-lang/rust#155055 (UI automation) - rust-lang/rust#155062 (Move tests from `tests/ui/issues/` to appropriate directories) - rust-lang/rust#155131 (Stabilize feature `uint_bit_width`) - rust-lang/rust#155147 (Stabilize feature `int_lowest_highest_one`) - rust-lang/rust#155174 (Improve emission of `UnknownDiagnosticAttribute` lint) - rust-lang/rust#155194 (Fix manpage version replacement and use verbose version)

…s-cg-clif, r=bjorn3 cg_clif: Don't show verbose run-make cmd output for passing tests Uses `--verbose-run-make-subprocess-output=false` added in rust-lang#154587 to suppress verbose cmd dump for passing `run-make` tests. Closes rust-lang#154069.

rustbot assigned wesleywiser Mar 30, 2026

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2026

This comment has been minimized.

Sign in to view

Ayuse force-pushed the compiletest-quiet-run-make branch from ee8706b to d7cd840 Compare March 30, 2026 14:04

rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Mar 30, 2026

This comment has been minimized.

Sign in to view

rustbot assigned jieyouxu and unassigned wesleywiser Mar 30, 2026

jieyouxu mentioned this pull request Mar 31, 2026

Add --quiet flag to x.py and bootstrap to suppress output #154616

Merged

jieyouxu requested changes Apr 5, 2026

View reviewed changes

Comment thread src/tools/run-make-support/src/util.rs Outdated

Comment thread src/bootstrap/src/core/config/flags.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2026

jieyouxu reviewed Apr 5, 2026

View reviewed changes

Comment thread src/bootstrap/src/core/config/flags.rs Outdated

rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Apr 10, 2026

Ayuse changed the title ~~Add --quiet flag to suppress verbose run-make output for passing tests~~ Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests Apr 10, 2026

This comment has been minimized.

Sign in to view

Ayuse force-pushed the compiletest-quiet-run-make branch from 20bc08b to 6733ce9 Compare April 12, 2026 15:25

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 12, 2026

jieyouxu approved these changes Apr 13, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026

jieyouxu mentioned this pull request Apr 13, 2026

cg_clif: Don't show verbose run-make cmd output for passing tests #155220

Open

JonathanBrouwer mentioned this pull request Apr 13, 2026

Rollup of 4 pull requests #155224

Closed

JonathanBrouwer mentioned this pull request Apr 13, 2026

Rollup of 13 pull requests #155225

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Apr 13, 2026

Auto merge of #154587 - Ayuse:compiletest-quiet-run-make, r=<try>

0e801c0

Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests try-job: i686-msvc-2

JonathanBrouwer mentioned this pull request Apr 13, 2026

Rollup of 20 pull requests #155245

Closed

JonathanBrouwer mentioned this pull request Apr 13, 2026

Rollup of 19 pull requests #155253

Merged

rust-bors Bot merged commit 46997fb into rust-lang:main Apr 13, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone Apr 13, 2026

Uh oh!

Conversation

Ayuse commented Mar 30, 2026 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Ayuse commented Mar 30, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 5, 2026

Uh oh!

Uh oh!

rustbot commented Apr 10, 2026

Uh oh!

This comment has been minimized.

Ayuse commented Apr 12, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Apr 13, 2026

Uh oh!

JonathanBrouwer commented Apr 13, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Ayuse commented Mar 30, 2026 •

edited by jieyouxu

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading