cg_clif: Don't show verbose run-make cmd output for passing tests#155220
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom May 7, 2026
Merged
Conversation
rustbot
added
A-compiletest
jieyouxu
force-pushed
the
dont-verbose-print-success-cg-clif
branch
from
98bfbb0 to
30db41d
Compare
rustbot
added
the
S-waiting-on-review
Collaborator
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
rustbot
removed
the
S-waiting-on-author
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Sorry, forgot to assign... |
jieyouxu
removed
A-compiletest
jieyouxu
commented
Apr 14, 2026
|
|
||
| echo "[TEST] rustc test suite" | ||
| ./x.py test --stage 0 --test-args=--no-capture tests/{codegen-units,run-make,run-make-cargo,ui,incremental} | ||
| ./x.py test --stage 0 --no-capture --verbose-run-make-subprocess-output=false tests/{codegen-units,run-make,run-make-cargo,ui,incremental} |
Member
Author
There was a problem hiding this comment.
(Could you double-check if this goes back to the behavior that you wanted?)
Member
There was a problem hiding this comment.
I just tried it and I'm still getting a bunch of
running: LC_ALL="C" LD_LIBRARY_PATH="/home/bjorn/cg_clif/rust/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-whole-archive/rmake_out:/home/bjorn/cg_clif/rust/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib:/home/bjorn/cg_clif/rust/build/x86_64-unknown-linux-gnu/bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/home/bjorn/cg_clif/rust/../dist/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/bjorn/cg_clif/rust/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-whole-archive/rmake_out/directly_linked"
and
------extern-multiple-copies/rmake stdout------------------------------
------extern-multiple-copies/rmake stderr------------------------------
------------------------------------------
for tests that don't have any output. It is a big improvement though.
Member
Author
There was a problem hiding this comment.
Hm, I'll tune this in a follow-up.
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
|
@bors rollup=always |
rust-bors Bot
pushed a commit
that referenced
this pull request
May 7, 2026
…uwer Rollup of 10 pull requests Successful merges: - #146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - #154025 (Add `keepalive`, `set_keepalive` to `TcpStream` implementations) - #156024 (CFI: Fix LTO for `#![no_builtins]` crates with CFI) - #156243 (Move CrateInfo computation after codegen_crate) - #154846 (Add better default spans for the `Ty` impl of `QueryKey`) - #155220 (cg_clif: Don't show verbose run-make cmd output for passing tests) - #156204 (Implemented `PathBuf::into_string`) - #156245 (Move invocation_temp into OutputFilenames) - #156250 (add a few new solver normalization tests) - #156265 (Remove unused `ToStableHashKey` impls.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
--verbose-run-make-subprocess-output=falseadded in #154587 to suppress verbose cmd dump for passingrun-maketests.Closes #154069.