Skip to content

cg_clif: Don't show verbose run-make cmd output for passing tests #155220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
May 7, 2026
+1 −1
Merged

cg_clif: Don't show verbose run-make cmd output for passing tests #155220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_codegen_cranelift/scripts/test_rustc_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,5 +198,5 @@ index 073116933bd..c3e4578204d 100644
EOF

echo "[TEST] rustc test suite"
./x.py test --stage 0 --test-args=--no-capture tests/{codegen-units,run-make,run-make-cargo,ui,incremental}
./x.py test --stage 0 --no-capture --verbose-run-make-subprocess-output=false tests/{codegen-units,run-make,run-make-cargo,ui,incremental}
Copy link
Copy Markdown
Member Author

@jieyouxu jieyouxu Apr 14, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

(Could you double-check if this goes back to the behavior that you wanted?)

Copy link
Copy Markdown
Member

@bjorn3 bjorn3 May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it and I'm still getting a bunch of

running: LC_ALL="C" LD_LIBRARY_PATH="/home/bjorn/cg_clif/rust/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-whole-archive/rmake_out:/home/bjorn/cg_clif/rust/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib:/home/bjorn/cg_clif/rust/build/x86_64-unknown-linux-gnu/bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/home/bjorn/cg_clif/rust/../dist/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/bjorn/cg_clif/rust/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-whole-archive/rmake_out/directly_linked"

and

------extern-multiple-copies/rmake stdout------------------------------

------extern-multiple-copies/rmake stderr------------------------------

------------------------------------------

for tests that don't have any output. It is a big improvement though.

Copy link
Copy Markdown
Member Author

@jieyouxu jieyouxu May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'll tune this in a follow-up.

popd
Loading