Rip out rustc_layout_scalar_valid_range_* attribute support

[oli-obk]

View all comments

And either removes tests for it or replaces the uses with pattern types.

primarily fixes #135996

fixes #147761
fixes #133652

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the CTFE machinery

cc @RalfJung, @lcnr

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

[rustbot]

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 72 candidates
• Random selection from 18 candidates

[JonathanBrouwer]

Happy to review this
Love the branch name 🤣

r? me

[ChayimFriedman2]

Please revert the rust-analyzer changes. r-a needs to support old compilers, and also it doesn't even properly support pattern types yet.

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[mejrs]

There is some prose in the dev guide that will no longer apply.

The other complicated safety check is for writes to fields of layout constrained structs (such as NonNull). These are found by looking for the borrow or assignment expression and then visiting the subexpression being borrowed or assigned with a separate visitor.

https://rustc-dev-guide.rust-lang.org/unsafety-checking.html?other-checks-involving-unsafe

[rustbot]

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[oli-obk]

@bors try jobs=aarch64-msvc-1

[rust-bors]

☀️ Try build successful (CI)
Build commit: 3eeae45 (3eeae452f25cf4a3f8b4366878f7a926589ff5e4, parent: 44860d3e9ef700cac0b4a61d924f41f46bf1b447)

[ShoyuVanilla]

@bors r=RalfJung,ShoyuVanilla rollup

[rust-bors]

📌 Commit 11d88ee has been approved by RalfJung,ShoyuVanilla

It is now in the queue for this repository.

[JonathanBrouwer]

Just in case
@bors try jobs=dist-i586-gnu-i586-i686-musl

[rust-bors]

☀️ Try build successful (CI)
Build commit: fbdd0e8 (fbdd0e8994078c1ae7d692f98df45174d073b8e2, parent: 54f67d248b14af80be8f3adc2094dd4a84ec2115)

[Kobzol]

Looks like this broke our runtime benchmarks in rustc-perf, lol.

Cannot compile runtime benchmark nbody

Caused by:
    0: Failed to compile runtime benchmark `nbody`
    1: Failed to run cargo, exit code 101
       /home/collector/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-0.37.20/src/backend/linux_raw/io/errno.rs:28:25: error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
       /home/collector/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-0.37.20/src/backend/linux_raw/io/errno.rs:29:25: error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
       /home/collector/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-0.37.20/src/backend/linux_raw/io/errno.rs:28:25: error: cannot find attribute `rustc_layout_scalar_valid_range_start` in this scope
       /home/collector/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-0.37.20/src/backend/linux_raw/io/errno.rs:29:25: error: cannot find attribute `rustc_layout_scalar_valid_range_end` in this scope

[JonathanBrouwer]

This is because the rustix crate uses rustc internal attributes 💀
https://github.com/bytecodealliance/rustix/blob/9f588bc922f98d19fdb1f44cdb17f190d239b0eb/src/backend/linux_raw/io/errno.rs#L49