Skip to content

Hand-implement impl Debug for NumBuffer to avoid constraining T or printing MaybeUninit#156098

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
joshtriplett:num-buffer-debug
May 3, 2026
Merged

Hand-implement impl Debug for NumBuffer to avoid constraining T or printing MaybeUninit#156098
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
joshtriplett:num-buffer-debug

Conversation

@joshtriplett
Copy link
Copy Markdown
Member

The derived implementation requires T: Debug, and doesn't need to.

…r printing MaybeUninit

The derived implementation requires `T: Debug`, and doesn't need to.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 3, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, nia-e, scottmcm

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 3, 2026
@GuillaumeGomez
Copy link
Copy Markdown
Member

Thanks!

r? me

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 3, 2026

📌 Commit df8a13e has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 3, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2026
rust-bors Bot pushed a commit that referenced this pull request May 3, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #156073 ([rustdoc] Fix `doc_cfg` feature on reexports)
 - #152216 (Fix 'assign to data in an index of' collection suggestions)
 - #155433 (Rip out rustc_layout_scalar_valid_range_* attribute support)
 - #156098 (Hand-implement `impl Debug for NumBuffer` to avoid constraining `T` or printing MaybeUninit)
@rust-bors rust-bors Bot merged commit 0d98c12 into rust-lang:main May 3, 2026
11 checks passed
rust-timer added a commit that referenced this pull request May 3, 2026
Rollup merge of #156098 - joshtriplett:num-buffer-debug, r=GuillaumeGomez

Hand-implement `impl Debug for NumBuffer` to avoid constraining `T` or printing MaybeUninit

The derived implementation requires `T: Debug`, and doesn't need to.
@rustbot rustbot added this to the 1.97.0 milestone May 3, 2026
@joshtriplett joshtriplett deleted the num-buffer-debug branch May 3, 2026 23:34
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request May 4, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#156073 ([rustdoc] Fix `doc_cfg` feature on reexports)
 - rust-lang/rust#152216 (Fix 'assign to data in an index of' collection suggestions)
 - rust-lang/rust#155433 (Rip out rustc_layout_scalar_valid_range_* attribute support)
 - rust-lang/rust#156098 (Hand-implement `impl Debug for NumBuffer` to avoid constraining `T` or printing MaybeUninit)
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request May 4, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#156073 ([rustdoc] Fix `doc_cfg` feature on reexports)
 - rust-lang/rust#152216 (Fix 'assign to data in an index of' collection suggestions)
 - rust-lang/rust#155433 (Rip out rustc_layout_scalar_valid_range_* attribute support)
 - rust-lang/rust#156098 (Hand-implement `impl Debug for NumBuffer` to avoid constraining `T` or printing MaybeUninit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants