Skip to content

Add error explanations for E0185, E0186, E0202, E0326. Fix E0053. - #25593

Merged
bors merged 4 commits into
rust-lang:masterfrom
nham:E0210_E0326
May 26, 2015
Merged

bors merged 4 commits into
rust-lang:masterfrom
nham:E0210_E0326

Conversation

@nham

@nham nham commented May 19, 2015

Copy link
Copy Markdown
Contributor

Changes:

  • adds explanations for E0185, E0186, E0202, E0326
  • fixes the explanation for E0053. The previous description was too narrow; there are other error cases.
  • changes the error message for E0202 to be specific for associated types, since it seems inherent associated constants are implemented.

Part of #24407

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

Comment thread src/librustc_typeck/diagnostics.rs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this mistakenly include &self?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Fixed, thanks.

@alexcrichton

Copy link
Copy Markdown
Member

r=me with just a minor nit, thanks!

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 1486508

@nham

nham commented May 20, 2015

Copy link
Copy Markdown
Contributor Author

@alexcrichton I just realized I missed a test with the E0202 change. I've fixed it and it now passes make check-stage1

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ cc9d1de

@bors

bors commented May 26, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cc9d1de with merge 6a003ab...

bors added a commit that referenced this pull request May 26, 2015
Changes:

 - adds explanations for E0185, E0186, E0202, E0326
 - fixes the explanation for E0053. The previous description was too narrow; there are other error cases.
 - changes the error message for E0202 to be specific for associated types, since it seems inherent associated constants are implemented.

Part of #24407
@bors

bors commented May 26, 2015

Copy link
Copy Markdown
Collaborator

@bors
bors merged commit cc9d1de into rust-lang:master May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants