Skip to content

Add 9 more error explanations, improve some error messages. #25688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2015

Conversation

nham
Copy link
Contributor

@nham nham commented May 21, 2015

  • Adds explanations for E0055, E0089, E0192, E0261-E0263, E0318
  • Improves explanations for E0250, E0368, E0372.
  • Converts 15 diagnostics to have error codes (E0380-E0394). Adds an explanation for E0380.
  • The E0087-E0090 messages currently look like "expected {} parameter(s) found {} parameter(s)". This changes them to either use "parameter" or "parameters", based on the number.

This is, in part, more progress towards #24407

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@nham
Copy link
Contributor Author

nham commented May 24, 2015

Of the new error codes (E0380-E0394), I've managed to trigger every error except E0385, E0388, and E0389.

By the way, it seems like E0385 might not be possible to trigger, because the AliasableOther variant doesn't seem to ever be constructed:

$ grep -r "AliasableOther" src/
src/librustc/middle/mem_categorization.rs:    AliasableOther,
src/librustc_borrowck/borrowck/mod.rs:            mc::AliasableOther => {

@nham nham force-pushed the E0055_E0192 branch 2 times, most recently from 5a7da25 to 412e549 Compare May 24, 2015 22:10
@nham nham changed the title Add 8 more error explanations, improve some error messages. Add 9 more error explanations, improve some error messages. May 24, 2015
@alexcrichton
Copy link
Member

@bors: r+ 412e549

Nice!

@bors
Copy link
Collaborator

bors commented May 26, 2015

☔ The latest upstream changes (presumably #25593) made this pull request unmergeable. Please resolve the merge conflicts.

@nham
Copy link
Contributor Author

nham commented May 26, 2015

Rebased.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented May 26, 2015

📌 Commit 570a043 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented May 26, 2015

⌛ Testing commit 570a043 with merge fe85342...

bors added a commit that referenced this pull request May 26, 2015
 - Adds explanations for E0055, E0089, E0192, E0261-E0263, E0318
 - Improves explanations for E0250, E0368, E0372.
 - Converts 15 diagnostics to have error codes (E0380-E0394). Adds an explanation for E0380.
 - The E0087-E0090 messages currently look like "expected {} parameter(s) found {} parameter(s)". This changes them to either use "parameter" or "parameters", based on the number.

This is, in part, more progress towards #24407
@bors bors merged commit 570a043 into rust-lang:master May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants