-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix E0449 #36411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix E0449 #36411
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
LGTM. Please squash all your commits first. |
69c4df1
to
326ac3d
Compare
Okay, squashed! |
Just realized this should have a test. r? @jonathandturner |
@jonathandturner I'm not familiar with the testing setup of Rust, so could you explain to me how to add a test to this? It looks like there already is a compile-fail test for this, but I don't know how to update it to this change. It passes the test, but the test is not very specific. |
@ChristopherDumas - I wrote a blog post to help with this. Specifically, check out the Extra Credit section of the blog post. It explains that there are quirks in the unit testing tool where it won't test labels until you put in your first NOTE test. |
Thank you, I'll check that out. |
☔ The latest upstream changes (presumably #36761) made this pull request unmergeable. Please resolve the merge conflicts. |
We landed some fixes to E0449 recently, which I think fix the issue. If there are additional changes that need to be made, you can rebase and send us a new PR. |
Closing due to inactivity, but feel free to resubmit with a rebase! |
A fix for issue #35924.