Update E0425, E0446, E0449 #36761
Merged
Update E0425, E0446, E0449 #36761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@bors: r+ |
Collaborator
|
📌 Commit 2fa91b2 has been approved by |
src/librustc_privacy/lib.rs
Outdated
| span_err!(self.tcx.sess, ty.span, E0446, | ||
| let mut err = struct_span_err!(self.tcx.sess, ty.span, E0446, | ||
| "private type in public interface"); | ||
| err.span_label(ty.span, &format!("private type can't be public")); |
Contributor
There was a problem hiding this comment.
Pretty strange tautological wording for the label.
Something like "can't leak private type" or "private type can't escape" maybe?
Or at least "private type can't become public"?
Contributor
Author
There was a problem hiding this comment.
@petrochenkov - yeah, those could also work. That reminds me that we need to start putting together a Rust error styleguide for future errors as well.
Contributor
There was a problem hiding this comment.
I like @petrochenkov 's suggestion of "can't leak private type"
Contributor
Author
There was a problem hiding this comment.
The two votes have it :) I'll update
Contributor
Author
|
@bors r=nrc |
Collaborator
|
📌 Commit c0f29fd has been approved by |
Collaborator
Collaborator
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #35343, #35923, and #35924. Part of #35233
Specifically, this adds labels to these error messages following the suggestions in the attached bugs.
r? @nrc