-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update Clippy #89328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Clippy #89328
Conversation
self_named_constructor -> self_named_constructors append_instead_of_extend -> extend_with_drain
[beta] Backport: Rename two lints to comply with our lint naming convention self_named_constructor -> self_named_constructors append_instead_of_extend -> extend_with_drain changelog: none r? `@ghost`
Adapts clippy for fe1a7f7
Update Clippy r? `@Manishearth`
Allow giving reasons for `disallowed_methods` Fixes rust-lang#7609. This permits writing the config for `disallowed-methods` as either a list of strings (like before) or a list of tables, where each table gives the path to the disallowed method and an optional reason for why the method is disallowed. changelog: Allow giving reasons for [`disallowed_methods`]
Add new lint `iter_not_returning_iterator` Add new lint [`iter_not_returning_iterator`] to detect method `iter()` or `iter_mut()` returning a type not implementing `Iterator` changelog: Add new lint [`iter_not_returning_iterator`]
Backport remerge This is to keep the backported commit in the repository before force pushing the new beta branch. r? `@ghost` changelog: none (literally none)
Fix derivable impl false positives fix rust-lang#7654 fix rust-lang#7655 changelog: none (not released)
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
@bors r+ p=1 we've got some CI flakiness in GHA but let's see how this goes |
📌 Commit d0fb9db has been approved by |
Reopen the PR? |
eh, we can just wait for bors to run full tests. |
⌛ Testing commit d0fb9db with merge c082958a881380b02c2f322e66cbdd10d7435f0b... |
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6f608ce): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Delayed Clippy sync
r? @Manishearth