Don't enable the hyper http1 feature now that hyper 0.14.2 is out #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from hyper 0.14.2 http connection types don't require a specific proto feature to be enabled in order to be accessed.
|
Uhm, okay so this is all very weird. We always send the ALPN protocols h2 and http/1.1 which means the server is free to choose either, meaning that technically hyper-rustls requires hyper to support both these protocols. I'm discussing this over in hyper-tls which has the same issue: hyperium/hyper-tls#85 (comment) |
|
If ALPN is always handled then we are already doing it wrong, since we only enable |
|
Yeah that's what I noticed as well. So this likely means that ALPN will need to be somewhat opt-in, which I'm honestly not liking that much as that will probably mean that a lot of people will completely miss that ALPN may need to be activated to get http2 support. |
|
I think #144 effectively mitigates this, right? |
|
Right. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from hyper 0.14.2 http connection types don't require a specific proto feature to be enabled in order to be accessed.
See hyperium/hyper#2377