fix: Only report http2 support if the http2 feature is enabled #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g2p
reviewed
Feb 11, 2021
src/connector.rs
Outdated
Comment on lines
68
to
72
| #[cfg(not(feature = "http2"))] | ||
| { | ||
| config.alpn_protocols = vec![b"http/1.1".to_vec()]; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think alpn_protocols should just be omitted if it only contains "http/1.1".
|
|
|
Any updates on this? |
|
This makes sense to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143