-
Notifications
You must be signed in to change notification settings - Fork 221
harmonize npm pkgs part3 #4237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harmonize npm pkgs part3 #4237
Conversation
a597f6b
to
775639f
Compare
775639f
to
ffd9077
Compare
JQuery = require('jquery') | ||
dom = new JSDOM("", { runScripts: "dangerously" }) | ||
_jQuery_cached = JQuery(dom.window); | ||
cb(_jQuery_cached) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, cool!
This (maybe?) breaks manage-* on kucalc. All the manage-* images crash like so:
It's possible though that that some other PR between 11/2 and now actually broke manage. I'm going to try to fix this. |
Hmmm... OK, we use ts-node caching VERY heavily, and I would say CoCalc massively uses it for halfway decent performance. Without caching every single project startup (in cc-in-cc dev mode) requires compiling every single ts file and will take about one minute (every single time!). Probably a lot of other things we build are much slower. Also, all manage, hub, etc., services will start up MUCH more slowly. ts-node completely eliminated caching support, due to a problem with how hashes are computed for dependent files: TypeStrong/ts-node#672 The current behavior is just to silently ignore requesting to use caching, e.g., where we write
with current ts-node it just doesn't work at all. So that's not so good. I'm going to push another patch that reverts all changes to the ts-node back to 1.5 years ago. Probably the right solution is to set this TS_NODE_TRANSPILE_ONLY environment variable for all containers where we run typescript code in production. For development, I don't know what we should do (e.g., for projects when doing cc-in-cc dev -- do we want to have a special way to run them that doesn't just strip the typescript, but by default we do strip the typescript?) See #4253 |
Rebuilding elsewhere got rid of the crashes, so that may have been a caching issue. However, the fact is we need caching, so we have to revert ts-node. |
Description
further updating packages (after "take2" branch)
this section is informative (i.e. don't update to immutable@4 blindly!), but outdated
in particular, the more restrictive typing in util/sync needs to be checked. e.g. in one case I made the note:
sync tests pass, though
hmm, something is odd, when loading a jupyter notebook the hub and project hub use up a lot of memory, produce a lot of output, etc.
I've ditched the immutable js update and it's back at an "@3" version – except for the webapp, where I don't dare to downgrade it.
The changes I had to make to the sync lib are in this closed and never merged PR. They certainly introduce problems, which aren't picked up by the tests.
Testing Steps
Relevant Issues
Checklist:
Front end:
~/.smc/local_hub/local_hub.log
./w
in/src
./start_hub.py
in/src/dev/project