fix(tasks): newly assigned None in registry#2381
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2381 +/- ##
=============================================
+ Coverage 87.090% 87.107% +0.017%
=============================================
Files 60 60
Lines 5004 5003 -1
Branches 905 905
=============================================
Hits 4358 4358
Misses 472 472
+ Partials 174 173 -1
Continue to review full report at Codecov.
|
ahopkins
reviewed
Jan 17, 2022
None in registry
Member
|
Can you add a unit test? |
Member
Author
|
All tests passed! I'm not sure if the test I wrote is correct. |
ahopkins
approved these changes
Feb 8, 2022
ChihweiLHBird
pushed a commit
to ChihweiLHBird/sanic
that referenced
this pull request
Jun 1, 2022
1 task
ashleysommer
added a commit
to ashleysommer/sanic
that referenced
this pull request
Jun 26, 2024
ahopkins
added a commit
that referenced
this pull request
Jun 27, 2024
) * Undo bug introduced by #2381, revert to super() protocol abort behavior. * Smarter transport stream close() and abort() Rather than simply calling `abort()` at a set interval after calling `close()`, we implement a mechanism to detect if any data is still in the transport write buffer after close is called, and schedules an async close operation to wait until the transport has finished, or finally calls abort after a reasonable timeout. * Add GRACEFUL_TCP_CLOSE_TIMEOUT as the timeout param * Unrelated E721 change --------- Co-authored-by: Adam Hopkins <adam@amhopkins.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to reproduce?
sanic/sanic/app.py
Lines 1273 to 1274 in b8d9914
If a name is not registered during create_task, the following name is obtained as
Task-1, so the error that occurred because it is newly assigned has been resolved.