Skip to content

fix(tasks): newly assigned None in registry #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahopkins merged 5 commits into from
Feb 8, 2022
Merged

fix(tasks): newly assigned None in registry #2381

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da29fe0
fix(app): set name when registered
SaidBySolo Jan 17, 2022
1a828a3
test(tasks): add test code
SaidBySolo Jan 17, 2022
235cd77
fix(tasks): newly assigned None in registry
SaidBySolo Jan 18, 2022
fa9a438
test(tasks): add unit test
SaidBySolo Jan 18, 2022
9476754
Merge branch 'main' into set_name_when_registered
SaidBySolo Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sanic/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,6 +1179,8 @@ def _loop_add_task(
task = loop.create_task(prepped, name=name)

if name and register and sys.version_info > (3, 7):
if isinstance(task, Task):
task.set_name(name)
Comment thread
SaidBySolo marked this conversation as resolved.
Outdated
app._task_registry[name] = task

return task
Expand Down
10 changes: 10 additions & 0 deletions tests/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,16 @@ async def test_purge_tasks(app: Sanic):

assert len(app._task_registry) == 0

async def test_purge_tasks_when_create_task(app: Sanic):
app.add_task(asyncio.create_task(dummy(3)), name="dummy")

await app.cancel_task("dummy")

assert len(app._task_registry) == 1

app.purge_tasks()

assert len(app._task_registry) == 0

def test_shutdown_tasks_on_app_stop():
class TestSanic(Sanic):
Expand Down