bump some versions (Scala, MiMa) #275

SethTisue · 2019-12-10T05:33:22Z

No description provided.

SethTisue · 2019-12-10T06:06:46Z

https://travis-ci.org/scala/scala-collection-compat/jobs/623030067

[error] Test BinaryCompaTest.compat failed: java.lang.NoSuchMethodError: 'scala.collection.mutable.HashSet com.typesafe.tools.mima.core.Settings.allSettings()', took 0.213 sec
593

SethTisue · 2019-12-10T06:33:56Z

now it fails with

[error] Test BinaryCompaTest.compat failed: expected:<List()> but was:<List(IncompatibleSignatureProblem(def id: (Lscala.collection.Iterable;Lscala.collection.generic.CanBuildFrom;)Lscala.collection.Iterable;,def id: (Lscala.collection.Iterable;Lscala.collection.generic.CanBuildFrom;)Lscala.collection.Iterable;), IncompatibleSignatureProblem(def id: (Lscala.collection.Iterable;Lscala.collection.generic.CanBuildFrom;)Lscala.collection.Iterable;,def id: (Lscala.collection.Iterable;Lscala.collection.generic.CanBuildFrom;)Lscala.collection.Iterable;))>

it is past my bedtime, I will resume tomorrow

SethTisue · 2019-12-11T03:47:39Z

well, this has been confusing.

if we go from Scala 2.12.8 to 2.12.10, [error] Test BinaryCompaTest.compat failed: java.lang.NoSuchMethodError: com.typesafe.tools.mima.core.Settings.allSettings()Lscala/collection/mutable/HashSet;, took 0.169 sec

that error can be made to go away with:

-    libraryDependencies += "com.typesafe" %% "mima-reporter" % "0.3.0" % Test,
+    libraryDependencies += "com.typesafe" %% "mima-core" % "0.6.1" % Test,

and being on the latest MiMa is in any case desirable.

but if we do that we get

[error] Test BinaryCompaTest.compat failed: expected:<List()> but was:<List(IncompatibleSignatureProblem(def id: (Lscala.collection.Iterable;Lscala.collection.generic.CanBuildFrom;)Lscala.collection.Iterable;,def id: (Lscala.collection.Iterable;Lscala.collection.generic.CanBuildFrom;)Lscala.collection.Iterable;), IncompatibleSignatureProblem(def id: (Lscala.collection.Iterable;Lscala.collection.generic.CanBuildFrom;)Lscala.collection.Iterable;,def id: (Lscala.collection.Iterable;Lscala.collection.generic.CanBuildFrom;)Lscala.collection.Iterable;))>, took 0.237 sec

this is the check introduced by @smarter in #115

over in README.md at https://github.com/lightbend/mima , @dwijnand writes:

The IncompatibleSignature check compares the Signature, which includes the full signature including generic parameters. This can catch real incompatibilities, but also sometimes triggers for a change in generics that would not in fact cause problems at run time. To opt-out of this check you can filter them...

@dwijnand @julienrf do y'all have an opinion on whether this particular IncompatibleSignatureProblem is spurious or real?

julienrf · 2019-12-11T08:33:14Z

It seems spurious to me.

dwijnand · 2019-12-11T09:28:41Z

I added change so we can get more info, which yielded:

[error] Test BinaryCompaTest.compat failed: The following 2 problems were reported but not expected:
[error]   - static method id(scala.collection.Iterable,scala.collection.generic.CanBuildFrom)scala.collection.Iterable in class org.example.Lib has a different signature in new version, where it is <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<Lscala/runtime/Nothing$;TA;TC;>;)TC; rather than <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<TC;TA;TC;>;)TC;
[error]   - method id(scala.collection.Iterable,scala.collection.generic.CanBuildFrom)scala.collection.Iterable in object org.example.Lib has a different signature in new version, where it is <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<Lscala/runtime/Nothing$;TA;TC;>;)TC; rather than <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<TC;TA;TC;>;)TC;

broken down:

signature change in static and non-static method "id" of class "Lib":
old: <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<TC;TA;TC;>;)TC;
new: <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<Lscala/runtime/Nothing$;TA;TC;>;)TC;

In summary: the first type parameter of the CanBuildFrom went from a specific TC to Nothing.

That type parameter is -From: "the type of the underlying collection that requests a builder to be created". So, the library went from accepting CBF that takes TCs to a CBF that accepts Nothing. My assumption is that it never needed to build "from" TC because it only uses the def apply(): Builder[Elem, To] method, not the def apply(from: From): Builder[Elem, To] of CBF.

So I too believe the signature change can be ignored.

SethTisue · 2019-12-12T19:37:46Z

okay, thanks, I'll take care of it, but after the 2.1.3 release

dwijnand · 2019-12-14T17:48:24Z

binary-compat/test/src/test/scala/BinaryCompaTest.scala

+    val unexpectedDescriptions =
+      allProblems.iterator
+        .map(_.description("new"))
+        .map{x => println(x); x}


Probably should drop this.

dwijnand · 2019-12-14T17:48:37Z

binary-compat/test/src/test/scala/BinaryCompaTest.scala

+        .toList
+    val msg =
+      unexpectedDescriptions.mkString(
+        s"The following ${allProblems.size} problems were reported but not expected:\n  - ", "\n  - ", "\n")


unexpectedDescriptions.size

dwijnand · 2019-12-14T17:52:41Z

binary-compat/test/src/test/scala/BinaryCompaTest.scala

+        .map(_.description("new"))
+        .map{x => println(x); x}
+        .filterNot(_ == "static method id(scala.collection.Iterable,scala.collection.generic.CanBuildFrom)scala.collection.Iterable in class org.example.Lib has a different signature in new version, where it is <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<Lscala/runtime/Nothing$;TA;TC;>;)TC; rather than <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<TC;TA;TC;>;)TC;")
+        .filterNot(_ == "method id(scala.collection.Iterable,scala.collection.generic.CanBuildFrom)scala.collection.Iterable in object org.example.Lib has a different signature in new version, where it is <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<Lscala/runtime/Nothing$;TA;TC;>;)TC; rather than <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<TC;TA;TC;>;)TC;")


The, uhm, "standard" way to do this would be a ProblemFilter, which is Problem => Boolean and constructed with: https://github.com/lightbend/mima/blob/1788742d28e7ec073152fd900bd89ec618168b16/core/src/main/scala/com/typesafe/tools/mima/core/ProblemFilters.scala#L22

SethTisue · 2019-12-14T17:58:10Z

#284 adopts Dale's suggestions

SethTisue changed the title ~~bump Scala versions everywhere (2.12.0, 2.13.1)~~ bump Scala versions everywhere (2.12.10, 2.13.1) Dec 11, 2019

SethTisue changed the title ~~bump Scala versions everywhere (2.12.10, 2.13.1)~~ bump some versions (Scala, MiMa) Dec 11, 2019

SethTisue mentioned this pull request Dec 11, 2019

Preserve binary compatibility for Factory #115

Merged

SethTisue self-assigned this Dec 12, 2019

SethTisue and others added 4 commits December 12, 2019 17:38

bump Scala versions everywhere (2.12.0, 2.13.1)

781866b

fix expected/actual order in a test

17f84c5

Add detail to "BinaryCompaTest"

6f37a1a

use latest MiMa

7b3b80e

SethTisue merged commit c80cfe4 into scala:master Dec 13, 2019

SethTisue deleted the version-bumps branch December 13, 2019 21:24

dwijnand reviewed Dec 14, 2019

View reviewed changes

SethTisue mentioned this pull request Dec 14, 2019

code improvements to BinaryCompaTest #284

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump some versions (Scala, MiMa) #275

bump some versions (Scala, MiMa) #275

SethTisue commented Dec 10, 2019

SethTisue commented Dec 10, 2019

SethTisue commented Dec 10, 2019 •

edited by dwijnand

Loading

SethTisue commented Dec 11, 2019

julienrf commented Dec 11, 2019

dwijnand commented Dec 11, 2019

SethTisue commented Dec 12, 2019 •

edited

Loading

dwijnand Dec 14, 2019

dwijnand Dec 14, 2019

dwijnand Dec 14, 2019

SethTisue commented Dec 14, 2019

bump some versions (Scala, MiMa) #275

bump some versions (Scala, MiMa) #275

Conversation

SethTisue commented Dec 10, 2019

SethTisue commented Dec 10, 2019

SethTisue commented Dec 10, 2019 • edited by dwijnand Loading

SethTisue commented Dec 11, 2019

julienrf commented Dec 11, 2019

dwijnand commented Dec 11, 2019

SethTisue commented Dec 12, 2019 • edited Loading

dwijnand Dec 14, 2019

Choose a reason for hiding this comment

dwijnand Dec 14, 2019

Choose a reason for hiding this comment

dwijnand Dec 14, 2019

Choose a reason for hiding this comment

SethTisue commented Dec 14, 2019

SethTisue commented Dec 10, 2019 •

edited by dwijnand

Loading

SethTisue commented Dec 12, 2019 •

edited

Loading