Skip to content

code improvements to BinaryCompaTest #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2019
Merged

code improvements to BinaryCompaTest #284

merged 1 commit into from
Dec 15, 2019

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Dec 14, 2019 •
edited
Loading

sequel to #275. review by @dwijnand

@SethTisue SethTisue mentioned this pull request Dec 14, 2019
Merged
dwijnand
dwijnand approved these changes Dec 14, 2019
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SethTisue SethTisue merged commit b32553a into scala:master Dec 15, 2019
@SethTisue SethTisue deleted the bincompat-fixups branch December 15, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethTisue @dwijnand