Skip to content

2.12 community build omnibus ticket #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
13 of 16 tasks
adriaanm opened this issue Aug 13, 2016 · 6 comments
Closed
13 of 16 tasks

2.12 community build omnibus ticket #203

adriaanm opened this issue Aug 13, 2016 · 6 comments
Assignees
@adriaanm @SethTisue
Milestone
2.12.0

Comments

@adriaanm
Copy link
Contributor

adriaanm commented Aug 13, 2016 •
edited by SethTisue
Loading

submit PRs based on forks (see commit mentions below)
@adriaanm adriaanm added this to the 2.12.0-RC1 milestone Aug 13, 2016
adriaanm added a commit to adriaanm/akka that referenced this issue Aug 13, 2016
@adriaanm
add override for scala/scala#5331
069439e 
scala/scala-dev#203
adriaanm added a commit to adriaanm/slick that referenced this issue Aug 13, 2016
@adriaanm
add 'override' for scala/scala#5331
453e289 
scala/scala-dev#203
adriaanm added a commit to adriaanm/scala-js that referenced this issue Aug 13, 2016
@adriaanm
add 'override' for scala/scala#5331
917e2c6 
scala/scala-dev#203
@adriaanm
Copy link
Contributor Author

adriaanm commented Aug 13, 2016 •
edited
Loading

testing changes at https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/477/console

adriaanm added a commit to adriaanm/util that referenced this issue Aug 13, 2016
@adriaanm
Instead of now-final Tuple2, extend Product2
2bb041a 
Not sure the _1/_2 members are needed, but this is least impact.
You do lose pattern matching with , though.

Consider name-based pattern matching or making this a case class
to regain more efficient matching (that goes straight to the fields).

see scala/scala-dev#203
adriaanm added a commit to adriaanm/paradise that referenced this issue Aug 13, 2016
@adriaanm
fix compilation errors due to scala/scala#5141
63be4ac 
probably needs more work

see scala/scala-dev#203
@adriaanm
Copy link
Contributor Author

adriaanm commented Aug 14, 2016 •
edited
Loading

https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/477/consoleFull:

util-core/src/test/java/com/twitter/concurrent/SpoolCompilationTest.java:13:
 <B>$plus$plus(scala.Function0<com.twitter.util.Future<com.twitter.concurrent.Spool<B>>>) 
in com.twitter.concurrent.Spool 
and <B>$plus$plus(scala.Function0<com.twitter.concurrent.Spool<B>>) 
in com.twitter.concurrent.Spool have the same erasure, 
yet neither overrides the other
private static class OwnSpool extends AbstractSpool<String> {

adriaanm added a commit to adriaanm/community-builds that referenced this issue Aug 14, 2016
@adriaanm
disable tests for macro-paradise for now
02d68ee 
scala/scala-dev#203
adriaanm added a commit to adriaanm/community-builds that referenced this issue Aug 14, 2016
@adriaanm
disable tests for twitter-util for now
102dd8a 
scala/scala-dev#203
@adriaanm adriaanm mentioned this issue Aug 14, 2016
Merged
adriaanm added a commit to scala/community-build that referenced this issue Aug 14, 2016
@adriaanm
Make 2.12.x build green again (#254)
999f84a 
see scala/scala-dev#203
adriaanm added a commit to adriaanm/scala-js that referenced this issue Aug 19, 2016
@adriaanm
ValDef may contribute exported method symbol
e309046 
The ValDef of a trait val/deferred val in class/lazy val
has a method symbol, with the accessor DefDef following
later, in the fields phase

see scala/scala#5294

Community build follow-up: scala/scala-dev#203
adriaanm added a commit to adriaanm/scalaz that referenced this issue Aug 19, 2016
@adriaanm
Implicit val needs signature...
ededccf 
... to be considered during implicit search before
the position of said implicit val.

Revealed by: scala/scala#5294
Community build follow-up: scala/scala-dev#203
@SethTisue SethTisue mentioned this issue Aug 23, 2016
Closed
@adriaanm adriaanm mentioned this issue Aug 23, 2016
Merged
@szeiger
Copy link

szeiger commented Aug 29, 2016 •
edited
Loading

Akka has added a dependency on scala-java8-compat in the meantime, so we need to add that to the community build: scala/community-build#262

@szeiger szeiger mentioned this issue Aug 31, 2016
Closed
@SethTisue SethTisue mentioned this issue Aug 31, 2016
Closed
@szeiger szeiger mentioned this issue Sep 1, 2016
Merged
adriaanm added a commit to adriaanm/scalaz that referenced this issue Sep 1, 2016
@adriaanm
Implicit val needs signature...
dfb2c99 
... to be considered during implicit search before
the position of said implicit val.

Revealed by: scala/scala#5294
Community build follow-up: scala/scala-dev#203
@adriaanm adriaanm mentioned this issue Sep 1, 2016
Merged
szeiger pushed a commit to szeiger/slick that referenced this issue Sep 1, 2016
@adriaanm @szeiger
add 'override' for scala/scala#5331
f998232 
scala/scala-dev#203
@szeiger szeiger mentioned this issue Sep 1, 2016
Merged
@adriaanm adriaanm modified the milestones: 2.12.0, 2.12.0-RC1 Sep 6, 2016
xuwei-k pushed a commit to xuwei-k/scalaz that referenced this issue Sep 7, 2016
@adriaanm @xuwei-k
Implicit val needs signature to be considered during implicit search …
2583144 
…before the position of said implicit val.

Revealed by: scala/scala#5294
Community build follow-up: scala/scala-dev#203

(cherry picked from commit dfb2c99)
@SethTisue
Copy link
Member

some additional old notes from Adriaan:

yep -- akka & sbinary are fixed in my forks
sbt is due to removal of exit
shapeless is junit not seeing default methods
sbinary is using a -Y option we removed (edited)

@milessabin
Copy link

If there's anything you'd like me to do wrt shapeless to make your life easier please let me know.

@SethTisue SethTisue changed the title community build 2.12 community build omnibus ticket Sep 24, 2016
@SethTisue SethTisue mentioned this issue Sep 24, 2016
Closed
@SethTisue
Copy link
Member

the only remaining unchecked boxes here were macro-paradise (I opened scala/community-build#302 on it) and ScalaTest (which is now #230)

and there's sbinary, but I'm less concerned about that one. maybe it'll get picked up in a future sweep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriaanm adriaanm

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
4 participants
@szeiger @adriaanm @milessabin @SethTisue