Skip to content

Switch to Akka master branch for 2.12.x #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2016

Conversation

szeiger
Copy link
Contributor

@szeiger szeiger commented Aug 29, 2016

First build attempt failed due to missing new dependency scala-java8-compat: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/502/console

@szeiger
Copy link
Contributor Author

szeiger commented Aug 29, 2016

New build attempt that tries to include scala-java8-compat: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/503/

@szeiger
Copy link
Contributor Author

szeiger commented Aug 29, 2016

scala-java8-compat currently blocked on scala/scala#5367

@szeiger
Copy link
Contributor Author

szeiger commented Aug 29, 2016

New attempt with updated scala-java8-compat: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/504/

@SethTisue SethTisue self-assigned this Aug 30, 2016
@szeiger
Copy link
Contributor Author

szeiger commented Aug 30, 2016

For some reason dbuild includes the test sources in the generated javadoc source stubs, which trips up javadoc because we use assert as an identifier. This doesn't happen when building directly from sbt. Here's a new attempt at preventing that: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/506/

Apart from this issue, things are looking good for scala-java8-compat. The binary artifacts get published and the tests pass.

@szeiger
Copy link
Contributor Author

szeiger commented Aug 30, 2016

No luck building latest ScalaTest: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/507/console - Disabling the offending parts of Akka for now.

- Add scala-java8-compat to the build. It is now required by Akka.

- Disable test source compilation for some Akka projects. We don’t run
  the tests anyway and some sources depend on ScalaTest 3.0 and
  Scalactic (a transitive dependency of ScalaTest), both of which are
  currently not part of the community build.
@szeiger
Copy link
Contributor Author

szeiger commented Aug 30, 2016

Community build for Akka was succesful: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/510/console

Squashed into one commit. Review by @SethTisue

@SethTisue SethTisue merged commit 181ecb3 into scala:2.12.x Aug 30, 2016
@SethTisue SethTisue mentioned this pull request Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants