Provide compatibility with current Scala 2.12.x (close to RC1) #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the required `override` modifiers to trait methods that now extend default methods of Java interfaces. - Add casts in some of these methods because the Scala primitive types are not compatible at the type level with the (now inherited) Java boxed types. - Use the boxed JFunction types in BoxingTest because the generic ones do not exist anymore. - Tests in LambdaTest need to be commented out because usage from Java changed significantly after scala/scala#5298 but we can still cross-build the actual library against 2.11 and 2.12.0-M5. At some point we should consider branching.
szeiger
added a commit
to szeiger/community-builds
that referenced
this pull request
Aug 29, 2016
Switch to scala/scala-java8-compat#76 which should work on 2.12.x now that scala/scala#5367 was also merged.
|
Used in scala/community-build#262. Review by @SethTisue |
|
code LGTM "usage from Java changed significantly" — shouldn't that mean updates to README.md? |
|
I'm working on restoring some of the old functionality. Hopefully the end result will only require minor changes compared to M5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overridemodifiers to trait methods that nowextend default methods of Java interfaces.
are not compatible at the type level with the (now inherited) Java
boxed types.
do not exist anymore.
changed significantly after SD-121 Remove now-unneeded J{Function,Proc}N functional interfaces scala#5298
but we can still cross-build the actual library against 2.11 and
2.12.0-M5. At some point we should consider branching.