Skip to content

Set versionScheme of scala3-library artifact #13498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2021
Merged

Set versionScheme of scala3-library artifact #13498

merged 3 commits into from
Oct 11, 2021

Conversation

julienrf
Copy link
Contributor

The default behavior of sbt is to infer “package versioning policy”, which can cause issues like scala/scala-parallel-collections#193 (comment).

This PR declares the version scheme to “semver-spec”, although I am not sure how you check that this module effectively conforms to this versioning scheme (I suggest using sbt-version-policy for that).

@smarter
Copy link
Member

smarter commented Sep 10, 2021

The same scheme should also be set on scala3-interfaces and tasty-core.

@smarter smarter requested a review from sjrd September 10, 2021 10:39
@julienrf
Copy link
Contributor Author

@smarter Done in 82ec2dc

BTW, I’ve noticed that the MiMa settings are enabled only in the scala3-library-bootstrapped, is this normal?

@smarter
Copy link
Member

smarter commented Sep 10, 2021

No, I'd say they should be enabled in tasty-core and scala3-interfaces too.

@julienrf
Copy link
Contributor Author

Sorry, I was not clear. What I meant is that the MiMa settings are enabled on scala3-library-bootstrapped but not on scala3-library. It seems both modules have the same base directory so I guess this is not a real problem?

MiMa settings are also enabled for scala3-interfaces. But they are not enabled on tasty-core (nor on tasty-core-bootstrapped).

@sjrd
Copy link
Member

sjrd commented Sep 10, 2021

Sorry, I was not clear. What I meant is that the MiMa settings are enabled on scala3-library-bootstrapped but not on scala3-library. It seems both modules have the same base directory so I guess this is not a real problem?

scala3-library (non-bootstrapped) is never published, so it doesn't need any compatibility guarantee, and therefore does not need MiMa.

@julienrf
Copy link
Contributor Author

scala3-library (non-bootstrapped) is never published, so it doesn't need any compatibility guarantee, and therefore does not need MiMa.

OK, that was not clear because the error message we got was mentioning the artifact org.scala-lang:scala3-library.

@sjrd
Copy link
Member

sjrd commented Sep 10, 2021

Yes, it's confusing, but it's really scala3-library-bootstrapped that is published, under the public name of scala3-library.

@julienrf julienrf removed their assignment Sep 15, 2021
@julienrf
Copy link
Contributor Author

Should I merge it myself? I’m not sure about your process.

smarter
smarter reviewed Sep 15, 2021
View reviewed changes
@julienrf julienrf self-assigned this Sep 15, 2021
@SethTisue
Copy link
Member

seems like a good candidate for backporting to 3.0.x series

@smarter
Copy link
Member

smarter commented Sep 15, 2021

There won't be anymore 3.0.x now that 3.1.0 is in RC

@SethTisue SethTisue mentioned this pull request Sep 15, 2021
Merged
@smarter
Copy link
Member

smarter commented Sep 15, 2021

(It could be backported to the release-3.1.0 branch but we normally only backport fixes for regressions)

@smarter smarter merged commit f8b869b into scala:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter left review comments

@sjrd sjrd sjrd approved these changes

Assignees

@julienrf julienrf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienrf @smarter @sjrd @SethTisue