Fix #15055

[mbovel]

[test_windows_full]

[mbovel]

@som-snytt, would that make sense to use Path.getFileName here?

[mbovel]

would that make sense to use Path.getFileName here?

No, because using Path induces additional validation of the path that we do not want here:

java.nio.file.InvalidPathException: Illegal char <<> at index 0: <highlighting>

---

I forced-pushed a second attempt that just replaces / with File.separator.

[som-snytt]

I'll take a look (when fully awake), but there's no reason for virtual paths to respect the syntax of some random other file system (such as Windows).

[som-snytt]

I proposed converting higher up the food chain at SourceFile.virtual #15064

Alternatively, creating a VirtualFile could require supplying both path and name. Most usages are of the form <stuff> rather than fancy paths. That must be the intuition behind the constructor that takes only a name; but it would be more regular for that constructor to also split the incoming string. Maybe I will go ahead and do that. I'll compare current usages; probably anyone expecting to supply a path also supplied the content?

[som-snytt]

Also, I've been working under WSL for some time, and just revived my cygwin, so I'll try to test locally under windows. Worst case, actually try using windows tooling, shudder.

cygwin:

[?2004hsbt:scala3←[36m> ←[0m

I'm grateful for the person who wrote on SO to add -Dsbt.log.noformat=true. I always have to google it.

←[?1l←>←[?1000l←[?2004l←[?1h←=←[?2004hsbt:scala3>

Same with -no-colors. You can see why Scala 3's -color:never irks me at this point.

[som-snytt]

would that make sense to use Path.getFileName here?

worth adding that InteractiveDriver did that before the recent tweak.

I also considered that VirtualFile should require user to supply both path and simple name if they are not the same. Then the strings could be taken as opaque instead of structured.

[som-snytt]

these classes are still an unfortunate weak spot, or "experimental". Since VirtualDirectory uses / it seems more robust to say, No, virtual means not tied to your local conventions. The alternative PR makes SourceFile convert the slashes.