SourceFile converts File.separator #15064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
OK I verified under cygwin that it fails without and succeeds with this tweak. It's hard to read under the escape noise. |
som-snytt
force-pushed
the
tweak/hovertest
branch
from
ff21288 to
0d35999
Compare
|
This commit also removes some unused imports, because unused imports hasn't been merged yet. |
mbovel
approved these changes
Apr 28, 2022
griggt
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceFile normalizes the virtual path so that finding the last element always works.
The virtual path separator is always "/". (
VirtualDirectoryconstructs a path that way.)Previously,
InteractiveDriverusedPathto determine the simple "file name" component.Fixes #15055
[test_windows_full]