Fix #2324: Check contexts in right order when looking for idents #2327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic would look for members of a class in the outermost scope where the class is owner. But it should be the innermost scope.
smarter
reviewed
Apr 28, 2017
| @@ -2,7 +2,7 @@ package bar { object bippy extends (Double => String) { def apply(x: Double): St | |||
| package object println { def bippy(x: Int, y: Int, z: Int) = "(Int, Int, Int)" } | |||
| object Test { | |||
| def main(args: Array[String]): Unit = { | |||
| println(bar.bippy(5.5)) | |||
| println(bar.bippy(5.5)) // error | |||
| println(bar.bippy(1, 2, 3)) // error | |||
There was a problem hiding this comment.
Shouldn't there be two errors here now? One for the println and one for bippy. That's what happens in scalac.
There was a problem hiding this comment.
Yes, but that's unrelated. Maybe they have the same position in dotty, or we are more aggressive about propagating error types. Anyway we went from 1 to 2 errors, so it's an improvement :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic would look for members of a class in the outermost scope
where the class is owner. But it should be the innermost scope.