Skip to content

Fix #2324: Check contexts in right order when looking for idents #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2017
Merged

Fix #2324: Check contexts in right order when looking for idents #2327

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
184efe1
Fix #2324: Check contexts in right order when looking for idents
odersky Apr 28, 2017
c18da4d
Update neg test
odersky Apr 28, 2017
07f7b1f
Add pos test
odersky Apr 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/neg/i1641.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package bar { object bippy extends (Double => String) { def apply(x: Double): St
package object println { def bippy(x: Int, y: Int, z: Int) = "(Int, Int, Int)" }
object Test {
def main(args: Array[String]): Unit = {
println(bar.bippy(5.5))
println(bar.bippy(5.5)) // error
println(bar.bippy(1, 2, 3)) // error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be two errors here now? One for the println and one for bippy. That's what happens in scalac.

Copy link
Contributor Author

@odersky odersky Apr 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that's unrelated. Maybe they have the same position in dotty, or we are more aggressive about propagating error types. Anyway we went from 1 to 2 errors, so it's an improvement :-)

}
}