Leaner Context objects #3136
Leaner Context objects #3136
Conversation
This get rid of two fields when bootstrapping because inner objects are implemented as lazy vals which in Dotty requires a bitmap field.
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3136 to see the changes. Benchmarks is based on merge(s) with master |
@liufengyun This is a 404 error page, any idea why? :) |
|
Not for me. I can see that page. |
|
Maybe only accessible from inside EPFL? Actually no, works from Scala world :)
…On Sun, Sep 17, 2017, 16:39 Sébastien Doeraene ***@***.***> wrote:
Not for me. I can see that page.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3136 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABdYwUntNDJZM1HOIn7_BOGQWDsXiwzUks5sjT0zgaJpZM4PaKVO>
.
|
|
Hmm, http://dotty-bench.epfl.ch/3136/ works but http://dotty-bench.epfl.ch/3136 is a 404 for me. Weird. |
|
These results are way too similar to http://dotty-bench.epfl.ch/3133, makes me think there's a missing point in the graph between master and now, or that the settings of the benchmarks changed. |
|
The website is actually hosted by Github, but EPFL domain names must point
to an EPFL machine, so the Github site is wrapped in an iframe. 404 could
be a temporary error either on our machine or Github.
The site can also be accessed by liufengyun.github.io/bench .
Le 17 sept. 2017 5:41 PM, "Felix Mulder" <[email protected]> a
écrit :
Maybe only accessible from inside EPFL?
On Sun, Sep 17, 2017, 16:39 Sébastien Doeraene ***@***.***> wrote:
Not for me. I can see that page.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3136 (comment)>, or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABdYwUntNDJZM1HOIn7_
BOGQWDsXiwzUks5sjT0zgaJpZM4PaKVO>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3136 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAuDybY6DL-gAPwMri2jVFvfRg9A-2d6ks5sjT3BgaJpZM4PaKVO>
.
|
|
If I go to https://liufengyun.github.io/bench/3136 I get a 404, if I go to https://liufengyun.github.io/bench/3136/ it works. If I go to https://liufengyun.github.io/bench/3133 it redirects to https://liufengyun.github.io/bench/3133/ and works. ¯\_(ツ)_/¯ |
|
This seems to be some differing behaviours of different browsers. I've updated the code to always have the ending slash, hope that works reliably across all browsers. |
No description provided.