-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Empty PR to test the benchmarks again #3137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test performance please |
performance test scheduled: 1 job(s) in queue, 0 running. |
This morning I changed the forks and warmups for some noisy lines (mainly
Vector and exhaustivity check tests), that might explain some of the
changes.
Le 17 sept. 2017 5:47 PM, "Guillaume Martres" <notifications@github.com> a
écrit :
… test performance please
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3137 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAuDycaC-lnsoNDSwgzJWddOcRcUufxpks5sjT8EgaJpZM4PaL5T>
.
|
performance test scheduled: 1 job(s) in queue, 1 running. |
I think the bot decided to run the benchmarks again because you quoted the command :). |
Thanks for the catch @smarter . The duplicate job removed and system updated. Now commands have to start from a line, so quoted commands are excluded. |
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3137 to see the changes. Benchmarks is based on merge(s) with master |
Looks like the benchmark changes made a big difference, invalidating the results of #3133 and #3136. @liufengyun I suggest reverting the changes for now. In the future I guess we'll need to rerun the benchmarks for all points when we make changes like this. |
@smarter I've temporarily reverted the changes in liufengyun/bench@19cd60c on the server, which affects 5 lines. Now you can try again. Note that re-run all benchmarks is both computationally expensive and laborious, thus re-run is only justified when there's a compelling reason.
|
test performance please |
performance test scheduled: 1 job(s) in queue, 0 running. |
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3137/ to see the changes. Benchmarks is based on merge(s) with master |
This looks more reasonable to me. |
I'm suspicious.