Added error message for Symbol is not a value #1589 #3746
Conversation
benkobalog
commented
Jan 4, 2018
•
benkobalog
commented
- Added SymbolIsNotAValue error Message class
- Substituted the original error message at Checking.scala:526 with the new class and added a test
- Typo fix at Checking.scala:211
1. Added SymbolIsNotAValue error Message class 2. Substituted the original error message with the new class and added a test
benkobalog
changed the title
| @@ -208,7 +208,7 @@ object messages { | |||
|
|
|||
| case class WildcardOnTypeArgumentNotAllowedOnNew()(implicit ctx: Context) | |||
| extends Message(WildcardOnTypeArgumentNotAllowedOnNewID) { | |||
| val kind = "syntax" | |||
| val kind = "Syntax" | |||
There was a problem hiding this comment.
This was the only place where this string started with a lowercase. I assumed it was a typo, if somebody could confirm it, it would be good.
| val msg = hl"${symbol.show} is not a value" | ||
| val kind = "Type Mismatch" | ||
| val explanation = | ||
| hl"Scala or Java packages cannot be assigned to a value" |
There was a problem hiding this comment.
Scala packages can be used as values if they have a package object.
Java statics and packages cannot be used as a value.
There was a problem hiding this comment.
What should be the explanation then?
What are Java statics in this context? I guess not static fields because """object O {val a = Math.PI}""" compiles.
There was a problem hiding this comment.
I found the relevant conversation. I will write a better explanation based on this.
There was a problem hiding this comment.
I updated the explanation.
| @@ -2064,4 +2064,11 @@ object messages { | |||
| val explanation = | |||
| hl"An object that contains ${"@static"} members must have a companion class." | |||
| } | |||
|
|
|||
| case class SymbolIsNotAValue(symbol: Symbol)(implicit ctx: Context) extends Message(SymbolIsNotAValueID) { | |||
There was a problem hiding this comment.
SymbolIsNotAValue -> JavaSymbolIsNotAValue
Same for ID.
There was a problem hiding this comment.
I changed the class name, ID and test name too.
| @@ -2064,4 +2064,11 @@ object messages { | |||
| val explanation = | |||
| hl"An object that contains ${"@static"} members must have a companion class." | |||
| } | |||
|
|
|||
| case class SymbolIsNotAValue(symbol: Symbol)(implicit ctx: Context) extends Message(SymbolIsNotAValueID) { | |||
| val msg = hl"${symbol.show} is not a value" | |||
There was a problem hiding this comment.
You don't need show here $symbol.
There was a problem hiding this comment.
I removed the show method.
|
I will close this pull request and open a new one, because I couldn't properly resolve the conflicts (I'm new to this part of git) |
