Fix caching of TermRef #5808
Merged
Fix caching of TermRef #5808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
commented
Jan 29, 2019
| @@ -752,15 +752,15 @@ object Denotations { | |||
|
|
|||
| /** The TypeRef representing this type denotation at its original location. */ | |||
| def typeRef(implicit ctx: Context): TypeRef = | |||
| TypeRef(symbol.owner.thisType, symbol.name.asTypeName, this) | |||
| TypeRef(symbol.owner.thisType, symbol) | |||
There was a problem hiding this comment.
@odersky what about TermRef(symbol.owner.thisType, symbol).withDenot(this)?
This commit fixes a bug found in implementing ScalaTest macros, where `findMember("===")` returns 3
difference single denotations, but `alternatives.map(_.termRef)` returns 3
types of which the last 2 are the same. This causes an assertion failure in overloading resolution.
Unfortunately we are unable to create a minimized test.
liufengyun
force-pushed
the
fix-cache-termref
branch
from
59d981a to
9ed41c6
Compare
odersky
approved these changes
Jan 31, 2019
I'm not sure so sure, |
If we assume |
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 5, 2019
The fix restricts that we only call `.termRef` and `.typeRef` on `SymDenotation`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug found in implementing ScalaTest macros, where
findMember("===")returns 3difference single denotations, but
alternatives.map(_.termRef)returns 3types of which the last 2 are the same. This causes an assertion failure in overloading resolution.
Unfortunately we are unable to create a minimized test.