Skip to content

An alternative fix to #5808 #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2019
Merged

An alternative fix to #5808 #5851

merged 1 commit into from
Feb 6, 2019

Conversation

liufengyun
Copy link
Contributor

An alternative fix to #5808, which is potentially problematic.

The fix restricts that we only call .termRef and .typeRef on
SymDenotation.

@liufengyun
An alternative fix to scala#5808
24e9f52 
The fix restricts that we only call `.termRef` and `.typeRef` on
`SymDenotation`.
@liufengyun liufengyun requested a review from smarter February 6, 2019 08:54
smarter
smarter reviewed Feb 6, 2019
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK to me but I'd like @odersky to have a look.

@smarter smarter assigned odersky and unassigned smarter Feb 6, 2019
@smarter smarter requested a review from odersky February 6, 2019 13:55
odersky
odersky approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move. I agree it is better to remove these ops from Denotation if it is not clear what their semantics should be.

@odersky odersky merged commit 788b4fa into scala:master Feb 6, 2019
@liufengyun liufengyun deleted the fix-5808 branch February 6, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter left review comments

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liufengyun @smarter @odersky