sbt-dotty: Rework classpath and ScalaInstance handling, fix minimum sbt version check, release 0.3.0 #5835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
sbt-dotty-0.3.0
branch
from
fc6dc6f to
ec37d43
Compare
|
Rebased. Ping for review (we're doing a Dotty release next week so this is getting more pressing). |
sjrd
requested changes
Feb 11, 2019
smarter
force-pushed
the
sbt-dotty-0.3.0
branch
4 times, most recently
from
a320771 to
34f843c
Compare
|
Ping for second round of review. |
I don't think anyone uses it, and it won't be needed anymore once we use dotty as our stage0 compiler, so removing in the name of simplicity.
In particular, stop relying on zinc handling of the ScalaTool configuration (by setting managedScalaInstance to false) and instead fetch artifacts ourselves. Also document clearly what should end up on which classpath.
Now that we add dotty-library to libraryDependencies, we need to be more careful to make this work: libraryDependencies ~= (_.map(_.withDottyCompat(scalaVersion.value))) This is needed to keep the community-build working.
This fixes scala#5671. Also bump the minimum version to 1.2.7 due to scalaCompilerBridgeBinaryJar usage, etc.
smarter
force-pushed
the
sbt-dotty-0.3.0
branch
from
34f843c to
668a8b3
Compare
smarter
added a commit
to smarter/sbt
that referenced
this pull request
Feb 12, 2019
sbt-dotty 0.3.0 (scala/scala3#5835) sets `managedScalaInstance := false` and does everything by itself, so this isn't needed anymore.
smarter
added a commit
to smarter/sbt
that referenced
this pull request
Feb 12, 2019
sbt-dotty 0.3.0 (scala/scala3#5835) sets `managedScalaInstance := false` and does everything by itself, so this isn't needed anymore.
smarter
added a commit
to smarter/zinc
that referenced
this pull request
Feb 12, 2019
This was always a hack and isn't needed as of sbt-dotty 0.3.0 (scala/scala3#5835).
sjrd
approved these changes
Feb 13, 2019
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 14, 2019
In scala#5835 I changed the scalaInstance used for bootstrapped projects to use class directories instead of jars for the local dependencies, but this breaks the cache invalidation mechanism used by sbt to decide whether to keep using the same compiler instance or not, in particular this means that running: > dotty-library-bootstrapped/compile Then if we edit code in the compiler, we expect the next call to `dotty-library-bootstrapped/compile` to use the new compiler, but it kept using the original one since the cache wasn't invalidated.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 14, 2019
In scala#5835 I changed the scalaInstance used for bootstrapped projects to use class directories instead of jars for the local dependencies, but this breaks the cache invalidation mechanism used by sbt to decide whether to keep using the same compiler instance or not, in particular this means that running: > dotty-library-bootstrapped/compile Then if we edit code in the compiler, we expect the next call to `dotty-library-bootstrapped/compile` to use the new compiler, but it kept using the original one since the cache wasn't invalidated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.