Fix cache invalidation of compiler instance #5921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scala#5835 I changed the scalaInstance used for bootstrapped projects to use class directories instead of jars for the local dependencies, but this breaks the cache invalidation mechanism used by sbt to decide whether to keep using the same compiler instance or not, in particular this means that running: > dotty-library-bootstrapped/compile Then if we edit code in the compiler, we expect the next call to `dotty-library-bootstrapped/compile` to use the new compiler, but it kept using the original one since the cache wasn't invalidated.
smarter
force-pushed
the
fix/scalainstance-cache
branch
from
d5da8f0 to
3138bde
Compare
|
Might be easier to just use |
sjrd
approved these changes
Feb 14, 2019
|
Avoiding exportJars means that we don't go through jars when compiling the non-bootstrapped projects, so I'd rather not use it for now at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5835 I changed the scalaInstance used for bootstrapped projects to
use class directories instead of jars for the local dependencies, but
this breaks the cache invalidation mechanism used by sbt to decide whether
to keep using the same compiler instance or not, in particular this
means that running:
Then if we edit code in the compiler, we expect the next call to
dotty-library-bootstrapped/compileto use the new compiler, but itkept using the original one since the cache wasn't invalidated.